Skip to content

Resumable Code RFC sample code is missing #18265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majocha opened this issue Jan 23, 2025 · 2 comments
Open

Resumable Code RFC sample code is missing #18265

majocha opened this issue Jan 23, 2025 · 2 comments
Labels
Area-Documentation good first issue help wanted
Milestone
Backlog

Comments

@majocha
Copy link
Contributor

majocha commented Jan 23, 2025

At some point the sample code that resided in benchmarks/TaskPerf went missing.
https://github.com/dotnet/fsharp/tree/f45ef819b5310de521645dbc68ccbfc57f8edda4/tests/benchmarks/TaskPerf

In effect, all the links to it in Resumable Code RFC are broken.
@github-actions github-actions bot added this to the Backlog milestone Jan 23, 2025
@T-Gro
Copy link
Member

T-Gro commented Jan 23, 2025

Thanks for spotting this.
It would be better if the RFC pointed to snapshots (from F# 6 time of the repo).

@brianrourkeboll
Copy link
Contributor

I think they were removed in #16812. Should we update the RFC to use permalinks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Documentation good first issue help wanted
Projects
F# Compiler and Tooling
Status: New
Milestone
Backlog
Development

No branches or pull requests
3 participants
@majocha @brianrourkeboll @T-Gro