[Testing] - Enabled Test 29402 to Pass on Both CV1 and CV2 Handlers #29423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@prakashKannanSf3972! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with CarouselView's item retention during orientation changes by ensuring that tests always run in portrait mode.
- Added a TearDown method in the test case to reset device orientation to portrait.
- Updated XAML to use the standard CarouselView control instead of a legacy/custom control.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28523.cs | Added a TearDown method to enforce portrait orientation after the test. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue28930.xaml | Replaced legacy CarouselView1 with the standard CarouselView control. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
May 12, 2025
jsuarezruiz
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Cause
During the landscape-to-portrait transition, CarouselView fails to retain the expected item position, scrolling to the next item instead. Appium triggers a right-scroll, causing the test to fail in CV2 as Item 3 appears instead of the expected Item 2.
The test
CarouselViewItemShouldScaleProperlysets the device to landscape but doesn’t reset it to portrait. As a result, the next test,CarouselViewInLineBreakMode, starts in landscape and switches to portrait during execution, causing inconsistent behavior.This issue is unrelated to
LineBreakModeand stems from CarouselView’s item position handling during orientation changes. It has already been reported here: [https://github.com/CarouselView Item Changes Unexpectedly on Orientation Change in CV2 #28972]Description of Change
[TearDown]method to reset the app's orientation to portrait mode after theCarouselViewItemShouldScaleProperlytest is completed, ensuring a consistent test environment setup. The test now passes for both CV1 and CV2 handlers.Issues Fixed
Fixes #29402
Output
CV2_Failing_Before_Reset.mov
CV2_Passed_After_Reset.mov