specify full path for dotnet, when running dotnet compile-fsc

fix #65
but ref dotnet/msbuild#1669 to resolve correct dotnet host

Author: enricosada

src/FSharp.NET.Sdk/build/FSharp.NET.Core.Sdk.targets

@@ -123,12 +123,18 @@ this file.
         <!--STEP2 Create the dotnet-compile-fsc response file-->
         <PropertyGroup>
             <DotnetCompileFscResponseFilePath>$(_IntermediateOutputPathFull)dotnet-compile.rsp</DotnetCompileFscResponseFilePath>
+
+            <!-- ref https://github.com/Microsoft/msbuild/issues/1669
+                 the dotnet in PATH can be different from the dotnet who run msbuild,
+                 so i need to specify the full path. -->
+            <_DotNetHostExecutableName>$(MSBuildExtensionsPath)/../../dotnet</_DotNetHostExecutableName>
+            <_DotNetHostExecutableName Condition=" '$(OS)' == 'Windows_NT' ">$(_DotNetHostExecutableName).exe</_DotNetHostExecutableName>
         </PropertyGroup>
 
         <WriteLinesToFile File="$(DotnetCompileFscResponseFilePath)" Lines="@(DotnetCompileFscResponseLines)" Overwrite="True" />
 
         <!--STEP3 HACK: invoke dotnet-compile-fsc because already works-->
-        <Exec Command='dotnet compile-fsc "@$(DotnetCompileFscResponseFilePath)" ' />
+        <Exec Command='"$(_DotNetHostExecutableName)" compile-fsc "@$(DotnetCompileFscResponseFilePath)" ' />
     </Target>
 
     <!--End Required Task by .Common.target-->

test/dotnet-new.Tests/CommonScenarioTests.cs

@@ -131,5 +131,79 @@ public void TestPathWithBlank()
                 .Execute($"build {LogArgs}")
                 .Should().Pass();
         }
+
+        private string GetCurrentRID()
+        {
+            var rootPath = Temp.CreateDirectory().Path;
+
+            Func<string,TestCommand> test = n => new TestCommand(n) { WorkingDirectory = rootPath };
+            
+            var result = test("dotnet").ExecuteWithCapturedOutput($"--info");
+
+            result.Should().Pass();
+
+            var dotnetInfo = result.StdOut;
+
+            string rid = 
+                dotnetInfo
+                .Split(new string[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries)
+                .Select(s => s.Trim())
+                .Where(s => s.StartsWith("RID:"))
+                .Select(s => s.Replace("RID:", "").Trim())
+                .FirstOrDefault();
+
+            return rid;
+        }
+
+        private void CreateNoopExe(string intoDir, string name, bool fail = false)
+        {
+            var rootPath = Temp.CreateDirectory().Path;
+
+            TestAssets.CopyDirTo("Noop", rootPath);
+
+            Func<string,TestCommand> test = n => new TestCommand(n) { WorkingDirectory = rootPath };
+
+            string rid = GetCurrentRID();
+            string msbuildArgs = $"/p:AssemblyName={name} " + (fail? "/p:Fail=true" : "");
+
+            test("dotnet")
+                .Execute($"restore -r {rid} --no-cache {LogArgs} {RestoreSourcesArgs(NugetConfigSources)} {RestoreProps()} {msbuildArgs}")
+                .Should().Pass();
+            
+            test("dotnet")
+                .Execute($"publish -r {rid} -o \"{intoDir}\" {msbuildArgs}")
+                .Should().Pass();
+        }
+
+        [Fact]
+        public void DifferentDotnetInPATH()
+        {
+            var rootPath = Temp.CreateDirectory().Path;
+
+            var fakeDotnetDir = Path.Combine(rootPath, "dotnetsdk");
+
+            Directory.CreateDirectory(fakeDotnetDir);
+            CreateNoopExe(fakeDotnetDir, "dotnet", fail : true);
+
+            var appDir = Path.Combine(rootPath, "TestApp");
+
+            TestAssets.CopyDirTo("TestLibrary", appDir);
+            TestAssets.CopyDirTo("TestSuiteProps", appDir);
+
+            Func<string,TestCommand> test = name => new TestCommand(name) { WorkingDirectory = appDir };
+
+            test("dotnet")
+                .Execute($"restore --no-cache {LogArgs} {RestoreSourcesArgs(NugetConfigSources)} {RestoreProps()}")
+                .Should().Pass();
+
+            var dotnetPath = Microsoft.DotNet.Cli.Utils.Env.GetCommandPath("dotnet");
+
+            var newPATHEnvVar = fakeDotnetDir + Path.PathSeparator + GetEnvironmentVariable("PATH");
+            
+            test(dotnetPath)
+                .WithEnvironmentVariable("PATH", newPATHEnvVar)
+                .Execute($"build {LogArgs}")
+                .Should().Pass();
+        }
     }
 }

test/testAssets/Noop/Program.cs

@@ -0,0 +1,16 @@
+using System;
+
+namespace ConsoleApp
+{
+    class Program
+    {
+        static int Main(string[] args)
+        {
+#if FAIL
+            return 1;
+#else
+            return 0;
+#endif
+        }
+    }
+}

test/testAssets/Noop/noop.csproj

@@ -0,0 +1,19 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>netcoreapp1.0</TargetFramework>
+
+    <DefineConstants Condition=" '$(Fail)' != '' ">FAIL;@(DefineConstants)</DefineConstants>
+  </PropertyGroup>
+
+  <PropertyGroup Condition=" '$(SmallerFootprint)' != '' ">
+    <TargetFramework>netstandard1.6</TargetFramework>
+  </PropertyGroup>
+  
+  <ItemGroup Condition=" '$(SmallerFootprint)' != '' ">
+    <PackageReference Include="Microsoft.NETCore.Runtime.CoreCLR" Version="1.0.2" />
+    <PackageReference Include="Microsoft.NETCore.DotNetHostPolicy" Version="1.0.1" />
+  </ItemGroup>
+
+</Project>