General using cleanup in C# files (#10011)

* General using cleanup in C# files

This removes unnecessary using statements and moves them outside of the namespaces when they were inside them.

I cleaned up the headers a bit for several hundred files, but the cleanup there isn't exhaustive by any means. Changes are only to the tops of files.

To make this work a bit more cleanly I've added GlobalUsings.cs files to some of the assemblies.

* Replace HashHelper with simplified version. Other PR feedback.

* Fix PresentationFramework.csproj

* Add null check

* Change HRESULT namespaces to defaults

---------

Co-authored-by: Harshit Mishra <hmishra@microsoft.com>

Author: JeremyKuhne

src/Microsoft.DotNet.Wpf/src/Common/Graphics/Generated/wgx_commands.cs

@@ -11,11 +11,8 @@
 
 // This code is generated from mcg\generators\CommandStructure.cs
 
-using System;
-using System.Windows.Media.Composition;
 using System.Runtime.InteropServices;
 using System.Windows.Media.Effects;
-using System.Security;
 
 using BOOL = System.UInt32;
 

src/Microsoft.DotNet.Wpf/src/Common/Graphics/exports.cs

@@ -6,32 +6,15 @@
 // Description:
 //     Managed exports from MIL core.
 
-using System;
-using System.Collections;
-using System.ComponentModel;
-using System.Threading;
-using System.Windows;
-using System.Windows.Media;
 using System.Windows.Media.Imaging;
-using System.Windows.Media.Effects;
-using System.Windows.Media.Media3D;
 using System.Runtime.InteropServices;
-using System.Windows.Media.Animation;
 using MS.Internal;
-using MS.Internal.PresentationCore;
 using MS.Internal.Interop;
 using MS.Utility;
 using MS.Win32;
-using System.Diagnostics;
-using System.Collections.Generic;
-using System.Security;
-using Microsoft.Win32.SafeHandles;
-
-using UnsafeNativeMethods=MS.Win32.PresentationCore.UnsafeNativeMethods;
-using SafeNativeMethods=MS.Win32.PresentationCore.SafeNativeMethods;
-using HRESULT=MS.Internal.HRESULT;
-using SR=MS.Internal.PresentationCore.SR;
-using DllImport=MS.Internal.PresentationCore.DllImport;
+
+using UnsafeNativeMethods = MS.Win32.PresentationCore.UnsafeNativeMethods;
+using HRESULT = MS.Internal.HRESULT;
 
 /*
  *

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_av_types.cs

@@ -2,9 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Runtime.InteropServices;
-
 namespace System.Windows.Media
 {
     //

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_core_types.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-
-using System;
 using System.Runtime.InteropServices;
 
 namespace System.Windows.Media.Composition

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_exports.cs

@@ -2,17 +2,11 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-
-using System;
 using System.Windows;
 using System.Windows.Media;
-using System.Windows.Media.Composition;
 using System.Windows.Media.Imaging;
 using System.Runtime.InteropServices;
 
-using System.Security;
-using MS.Internal.PresentationCore;
-
 namespace MS.Internal
 {
     #region MILRenderTargetBitmap

src/Microsoft.DotNet.Wpf/src/Common/Graphics/wgx_render.cs

@@ -2,15 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-
-using System;
-using System.IO;
-using System.Windows;
-using System.Windows.Media.Composition;
 using System.Runtime.InteropServices;
-using System.Windows.Media;
-using System.Security;
-using SR=MS.Internal.PresentationCore.SR;
 
 namespace MS.Internal
 {

src/Microsoft.DotNet.Wpf/src/Common/src/MS/Internal/PixelUnit.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System;
-
 namespace MS.Internal
 {
     internal readonly struct PixelUnit

src/Microsoft.DotNet.Wpf/src/Common/src/System/IO/Compression/DeflateZLib/ZLibNative.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Runtime.InteropServices;
-using System.Security;
 
 namespace System.IO.Compression
 {

src/Microsoft.DotNet.Wpf/src/Extensions/PresentationFramework-SystemDrawing/SystemDrawingExtension.cs

@@ -5,15 +5,12 @@
 // Description: Helper methods for code that uses types from System.Drawing.
 
 using System;
-using System.Security;
 using System.Diagnostics.CodeAnalysis;
 using System.Drawing;
 using System.Drawing.Imaging;
-using System.Drawing.Printing;
 using System.IO;
 
 using System.Windows;
-using System.Windows.Media;
 using System.Windows.Media.Imaging;
 
 namespace MS.Internal

src/Microsoft.DotNet.Wpf/src/Extensions/PresentationFramework-SystemXml/XmlNodeComparer.cs

@@ -6,12 +6,10 @@
 
 using System;
 using System.Collections;
-using System.Collections.Generic;
 using System.ComponentModel;
 using System.Globalization;
 
 using System.Xml;
-using MS.Internal.Data;
 
 namespace MS.Internal.Data
 {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Localization/LocalizationDirectivesToLocFile.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
-
 namespace MS.Internal
 {
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Localization/LocalizationParserHooks.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System;
 using System.Collections;
 using System.IO;
 using System.Xml;

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/MarkupCompiler.cs

@@ -19,7 +19,6 @@
 using System.Reflection;
 using System.Globalization;
 using System.ComponentModel;
-using System.Security.Cryptography;
 
 using System.CodeDom;
 using System.CodeDom.Compiler;
@@ -29,14 +28,11 @@
 
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-
-using System.Threading;
 using MS.Internal.Markup;
 using MS.Internal.Tasks;
 using MS.Utility;   // for SR
 using Microsoft.Build.Utilities;
 using Microsoft.Build.Tasks.Windows;
-using System.Runtime.CompilerServices;
 
 namespace MS.Internal
 {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/ParserExtension.cs

@@ -19,8 +19,6 @@
 using System.Diagnostics;
 using System.Reflection;
 using System.CodeDom;
-using System.CodeDom.Compiler;
-using System.ComponentModel;
 using MS.Utility;   // for SR
 
 namespace MS.Internal

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/MarkupCompiler/PathInternal.cs

@@ -16,29 +16,10 @@
 #pragma warning disable 1634, 1691
 
 using System;
-using System.Xml;
 using System.IO;
 using System.Text;
-using System.Reflection;
-using System.Globalization;
-using System.ComponentModel;
-using System.Security.Cryptography;
-
-using System.CodeDom;
-using System.CodeDom.Compiler;
-using System.Collections;
-using System.Collections.Generic;
-using System.ComponentModel.Design.Serialization;
 
 using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
-
-using System.Threading;
-using MS.Internal.Markup;
-using MS.Internal.Tasks;
-using MS.Utility;   // for SR
-using Microsoft.Build.Utilities;
-using Microsoft.Build.Tasks.Windows;
 using System.Runtime.CompilerServices;
 
 namespace MS.Internal

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerLocalReference.cs

@@ -13,14 +13,10 @@
 using System;
 using System.IO;
 using System.Collections;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Text;
 
 using Microsoft.Build.Tasks.Windows;
-using Microsoft.Build.Framework;
-using Microsoft.Build.Utilities;
-using MS.Utility;
 
 namespace MS.Internal.Tasks
 {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerState.cs

@@ -12,15 +12,12 @@
 
 using System;
 using System.IO;
-using System.Collections;
 using System.Diagnostics;
 using System.Text;
 using System.Globalization;
 
 using Microsoft.Build.Tasks.Windows;
 using Microsoft.Build.Framework;
-using Microsoft.Build.Utilities;
-using MS.Utility;
 
 namespace MS.Internal.Tasks
 {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerWrapper.cs

@@ -18,10 +18,6 @@
 using System;
 using System.IO;
 using System.Collections;
-using System.Reflection;
-using System.Runtime.InteropServices;
-
-using MS.Internal.Markup;
 using Microsoft.Build.Utilities;
 using Microsoft.Build.Framework;
 using MS.Internal.Tasks;

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/IPersistFileCheckSum.cs

@@ -17,7 +17,6 @@
 
 using System;
 using System.Runtime.InteropServices;
-using System.Security;
 
 
 namespace MS.Internal

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/IVsMSBuildTaskFileManager.cs

@@ -18,9 +18,8 @@
 
 using System;
 using System.Runtime.InteropServices;
-using System.Security;
 
-    
+
 namespace MS.Internal
 {
     // <summary>

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/IncrementalCompileAnalyzer.cs

@@ -12,16 +12,12 @@
 
 using System;
 using System.IO;
-using System.Collections;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
 using System.Reflection;
 
 using Microsoft.Build.Tasks.Windows;
 using Microsoft.Build.Framework;
-using Microsoft.Build.Utilities;
-using MS.Utility;
 
 namespace MS.Internal.Tasks
 {

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/Shared.cs

@@ -10,10 +10,6 @@
 //
 //------------------------------------------------------------------------------
 
-using System;
-using System.IO;
-using System.Collections;
-
 namespace MS.Internal.Tasks
 {
     #region SharedStrings class

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/TaskFileService.cs

@@ -24,7 +24,6 @@
 using System.IO;
 using Microsoft.Build.Utilities;
 using Microsoft.Build.Tasks.Windows;
-using System.Diagnostics;
 using System.Text;
 using System.Security.Cryptography;
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/TaskHelper.cs

@@ -12,21 +12,14 @@
 
 using System;
 using System.IO;
-using System.Collections;
-using System.Text;
-using System.Runtime.InteropServices;
 
 using System.Globalization;
 using System.Diagnostics;
 using System.Reflection;
-using System.Resources;
 
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
-
-using Microsoft.Build.Tasks;
 using MS.Utility;
-using System.Collections.Generic;
 
 
 namespace MS.Internal.Tasks

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/FileClassifier.cs

@@ -10,13 +10,9 @@
 //---------------------------------------------------------------------------
 
 using System;
-using System.IO;
 using System.Collections.Generic;
 
 using System.Globalization;
-using System.Diagnostics;
-using System.Reflection;
-using System.Resources;
 using System.Runtime.InteropServices;
 
 

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/GenerateTemporaryTargetAssembly.cs

@@ -21,18 +21,13 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
-
-using System.Globalization;
 using System.Diagnostics;
-using System.Reflection;
-using System.Resources;
 using System.Xml;
 
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 
 using MS.Utility;
-using MS.Internal.Tasks;
 
 // Since we disable PreSharp warnings in this file, PreSharp warning is unknown to C# compiler.
 // We first need to disable warnings about unknown message numbers and unknown pragmas.