|
2 | 2 |
|
3 | 3 | Thank you for contributing to **WPF for .NET Core!** We ask that before you start work on a feature that you would like to contribute, please file an issue describing your proposed change: We will be happy to work with you to figure out the best approach, provide guidance and mentorship throughout feature development, and help avoid any wasted or duplicate effort.
|
4 | 4 |
|
5 |
| -#### What types of pull requests will be accepted before WPF for .NET Core General Availability in September? |
6 |
| - |
7 |
| -WPF for .NET Core is seeking functional and performance parity with .NET Framework to offer customers a direct porting path from .NET Framework. Given this, only the following will be considered: |
8 |
| - |
9 |
| -* Bug fixes that are not reproducible on .NET Framework |
10 |
| -* IL-neutral formatting changes done by Roslyn analyzers and automatic code fixers |
11 |
| -* Performance fixes that bring .NET Core to performance parity with .NET Framework |
12 |
| - |
13 |
| -All other changes will be tagged as 'future' and postponed until after .NET Core 3.0 GA in September. |
14 |
| - |
15 |
| -**Please see the chart below for more details.** |
16 |
| - |
17 |
| -| Category | Description | Accepted pre-GA | |
18 |
| -| --- | --- | :---: | |
19 |
| -| .NET Core code defect | .NET Core bugs that *are not* reproducible on .NET Framework will be accepted pre-GA. | :heavy_check_mark: | |
20 |
| -| .NET Framework code defect | Fixes for .NET Core bugs that are **also** reproducible on .NET Framework will not be accepted. (If this was a recent regression in .NET Framework 4.8, or this blocks a core scenario, then we will likely consider bugs in this category). | :x: | |
21 |
| -| .NET Core API change | An **enhancement** of an existing .NET Core API will not be accepted pre-GA. (We are also seeking to minimize deprecation and removal of APIs, unless they are unsupported by .NET core.)| :x: | |
22 |
| -| New API (feature addition, public API) | New features and public APIs will not be considered until after .NET Core 3.0 GA. | :x: | |
23 |
| -| Performance Optimization | We would like to achieve performance parity with .NET Framework. Fixes for performance regressions in .NET Core will be accepted, and other performance optimizations will be considered. | :heavy_check_mark: | |
24 |
| -| Automated code formatting change | Automated IL-neutral changes with an associated Roslyn analyzer or editor config update will be accepted. Automated changes that result in differences to the IL will be individually considered. | :heavy_check_mark: | |
25 |
| -| Manual code formatting change | Manual code formatting changes without an associated Roslyn analyzer or editor config update will not be accepted pre-GA. | :x: | |
26 |
| - |
27 | 5 | ### General Guidelines
|
28 | 6 |
|
29 | 7 | > 👉 **Remember\!** Your contributions may be incorporated into future versions of WPF\! Because of this, all pull requests will be subject to the same level of scrutiny for quality, coding standards, performance, globalization, accessibility, and compatibility as those of our internal contributors.
|
30 | 8 |
|
31 | 9 |
|
32 | 10 | * **DO** create an issue before creating a pull request.
|
33 | 11 | * **DO** create one pull request per Issue, and ensure that the Issue is linked in the pull request.
|
34 |
| -* **DO** follow our [coding and style guidelines](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md), and keep code changes as small as possible. |
| 12 | +* **DO** follow our [coding and style guidelines](https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/coding-style.md), and keep code changes as small as possible. |
35 | 13 | * **DO** check for additional occurrences of the same problem in other parts of the codebase before submitting your PR.
|
36 | 14 | * **DO** link the issue you are addressing in the pull request.
|
37 | 15 | * **DO** write a good description for your pull request. More detail is better. Describe why the change is being made and why you have chosen a particular solution. Describe any manual testing you performed to validate your change.
|
@@ -91,9 +69,3 @@ All other changes will be tagged as 'future' and postponed until after .NET Core
|
91 | 69 | 16. Finally, pre-milestone release, a full internal test pass is run. This test pass contains tens of thousands of tests across a large number of operating systems and machine configurations. If everything succeeds, the change (along with any others) will remain in master to be included in the next milestone release.
|
92 | 70 |
|
93 | 71 | 17. The repo is 'snapped' to a milestone release containing the PR.
|
94 |
| - |
95 |
| - |
96 |
| - |
97 |
| -### Would you like to contribute new features after September? |
98 |
| - |
99 |
| -Please open an issue describing what feature area you would like to work on. We will begin assigning community owners and WPF developer peers some time in the future. Thanks! |
0 commit comments