Skip to content

Fluent2 Editable ComboBox Issues #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #10656
robert-abeo opened this issue Feb 18, 2025 · 3 comments · May be fixed by #10818
Open
Tracked by #10656

Fluent2 Editable ComboBox Issues #10470

robert-abeo opened this issue Feb 18, 2025 · 3 comments · May be fixed by #10818
Labels
Win 11 Theming

Comments

@robert-abeo
Copy link

Description

The Fluent2 Editable ComboBox has a few issues:

  1. Background doesn't change when editing text (focused)
  2. It ideally needs to have the same border style as TextBox when unfocused. However, this may be a design decision (I disagree with) to keep an editable ComboBox looking more like a traditional ComboBox rather than a TextBox.

This is most noticeable in dark theme.

Reproduction Steps

.NET 9 Fluent theme
ComboBox with IsEditable="True"

Expected behavior

Editable ComboBox should match closely with TextBox styling.

Actual behavior

Unfocused ComboBox (top) is missing the more prominent "underline" bottom border indicating it is a text input.

Image

A focused ComboBox does not change the background when entering text.

Image

... as compared to TextBox

Image

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response
@lindexi
Copy link
Member

lindexi commented Feb 19, 2025 •
edited
Loading

Yes, I agree that editable ComboBox should match closely with TextBox styling.

The editing ComboBox in WinUI 3:

lindexi added a commit to lindexi/lindexi_gd that referenced this issue Feb 19, 2025
@lindexi
Fluent2 Editable ComboBox
c08661e 
dotnet/wpf#10470
@siagupta0202 siagupta0202 mentioned this issue Mar 26, 2025
Open
4 tasks
@dipeshmsft
Copy link
Member

I agree that Editable ComboBox should be nearer in style to a TextBox, like in case of focused and selection states.

However that would also mean that we are departing a little from what WinUI does.

Comments ? I will try to discuss this with internal design team and see what opinions they have.

@robert-abeo
Copy link
Author

@dipeshmsft Editable ComboBoxes was a late addition to UWP/WinUI and left a few things to be desired if I recall correctly. WPF was always more functional in this area.

That said, I think you are incorrect. What I'm asking for is exactly what is already done in WinUI. When I edit a combobox in the WinUI3 gallery it is as expected and is designed to look just like a TextBox. (background changes on focus, bottom border it accent color, etc.)

Image

@dipeshmsft dipeshmsft linked a pull request Apr 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Win 11 Theming
Projects
WPF Fluent Theming
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed ComboBox style and template dipeshmsft/wpf
3 participants
@lindexi @dipeshmsft @robert-abeo