use GenerateOpaqueString also for node secrets

drakkan · drakkan · commit 39c30c7d14b8 · 2024-11-27T19:06:25.000+01:00
this method will use rand.Text() with Go 1.24

Signed-off-by: Nicola Murino &lt;nicola.murino@gmail.com&gt;
diff --git a/internal/dataprovider/node.go b/internal/dataprovider/node.go
@@ -99,7 +99,7 @@ func (n *NodeData) validate() error {
 	if n.Proto != NodeProtoHTTP && n.Proto != NodeProtoHTTPS {
 		return util.NewValidationError(fmt.Sprintf("invalid node proto: %s", n.Proto))
 	}
-	n.Key = kms.NewPlainSecret(util.GenerateUniqueID())
+	n.Key = kms.NewPlainSecret(util.GenerateOpaqueString())
 	n.Key.SetAdditionalData(n.Host)
 	if err := n.Key.Encrypt(); err != nil {
 		return fmt.Errorf("unable to encrypt node key: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ func (n *NodeData) validate() error {`
`99`	`99`	`if n.Proto != NodeProtoHTTP && n.Proto != NodeProtoHTTPS {`
`100`	`100`	`return util.NewValidationError(fmt.Sprintf("invalid node proto: %s", n.Proto))`
`101`	`101`	`}`
`102`		`- n.Key = kms.NewPlainSecret(util.GenerateUniqueID())`
	`102`	`+ n.Key = kms.NewPlainSecret(util.GenerateOpaqueString())`
`103`	`103`	`n.Key.SetAdditionalData(n.Host)`
`104`	`104`	`if err := n.Key.Encrypt(); err != nil {`
`105`	`105`	`return fmt.Errorf("unable to encrypt node key: %w", err)`