Skip to content

Commit 68b95a3

Browse files
committed
Adress PR comments
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
1 parent 41f4f22 commit 68b95a3

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

packages/plugin-ext/src/common/plugin-protocol.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,14 @@ export interface PluginPackageContribution {
9898
terminal?: PluginPackageTerminal;
9999
}
100100

101+
export interface PluginPackageTerminalProfile {
102+
title: string,
103+
id: string,
104+
icon?: string
105+
}
106+
101107
export interface PluginPackageTerminal {
102-
profiles: {
103-
title: string,
104-
id: string,
105-
icon?: string
106-
}[]
108+
profiles: PluginPackageTerminalProfile[]
107109
}
108110

109111
export interface PluginPackageLocalization {

packages/terminal/src/browser/shell-terminal-profile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// *****************************************************************************
2-
// Copyright (C) 2022 ST Microelectronics and others.
2+
// Copyright (C) 2022 STMicroelectronics and others.
33
//
44
// This program and the accompanying materials are made available under the
55
// terms of the Eclipse Public License v. 2.0 which is available at

packages/terminal/src/browser/terminal-profile-service.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// *****************************************************************************
2-
// Copyright (C) 2022 ST Microelectronics and others.
2+
// Copyright (C) 2022 STMicroelectronics and others.
33
//
44
// This program and the accompanying materials are made available under the
55
// terms of the Eclipse Public License v. 2.0 which is available at
@@ -14,9 +14,8 @@
1414
// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
1515
// *****************************************************************************
1616

17-
import { Event } from '@theia/core';
17+
import { Emitter, Event } from '@theia/core';
1818
import { injectable } from '@theia/core/shared/inversify';
19-
import { Emitter } from '@theia/core/shared/vscode-languageserver-protocol';
2019
import { TerminalWidget } from './base/terminal-widget';
2120

2221
export const TerminalProfileService = Symbol('TerminalProfileService');

0 commit comments

Comments
 (0)