fix: do not free runtime dll for now

zaucy · zaucy · commit 7ee07cdea7ae · 2024-11-11T15:45:23.000-08:00
diff --git a/Source/Ecsact/Public/EcsactUnreal/Ecsact.cpp b/Source/Ecsact/Public/EcsactUnreal/Ecsact.cpp
@@ -81,7 +81,8 @@ auto FEcsactModule::UnloadEcsactRuntime() -> void {
 #undef RESET_ECSACT_FN
 
 	if(EcsactRuntimeHandle) {
-		FPlatformProcess::FreeDllHandle(EcsactRuntimeHandle);
+		// NOTE: Freeing the ecsact runtime causes unreal editor to crash
+		// FPlatformProcess::FreeDllHandle(EcsactRuntimeHandle);
 		EcsactRuntimeHandle = nullptr;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,8 @@ auto FEcsactModule::UnloadEcsactRuntime() -> void {`
`81`	`81`	`#undef RESET_ECSACT_FN`
`82`	`82`
`83`	`83`	`if(EcsactRuntimeHandle) {`
`84`		`- FPlatformProcess::FreeDllHandle(EcsactRuntimeHandle);`
	`84`	`+ // NOTE: Freeing the ecsact runtime causes unreal editor to crash`
	`85`	`+ // FPlatformProcess::FreeDllHandle(EcsactRuntimeHandle);`
`85`	`86`	`EcsactRuntimeHandle = nullptr;`
`86`	`87`	`}`
`87`	`88`	`}`