Skip to content

Commit f35ff22

Browse files
authored
update to .net9 (#197)
* update to .net9 * disable ca1515 * Change dockerfile to use net9
1 parent 77b1ed7 commit f35ff22

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# See https://hub.docker.com/_/microsoft-dotnet-runtime/ for list of tags for dotnet runtime
33
# See https://hub.docker.com/_/microsoft-dotnet-sdk for list of tags for dotnet sdk
44

5-
FROM mcr.microsoft.com/dotnet/runtime:8.0-alpine AS base
5+
FROM mcr.microsoft.com/dotnet/runtime:9.0-alpine AS base
66
# install powershell as per https://docs.microsoft.com/en-us/powershell/scripting/install/install-alpine
77
# the official docs install libssl1.1 but that started to fail and I tried ussing libssl3 which seems to work
88
ARG PWSH_VERSION=7.4.1
@@ -28,7 +28,7 @@ RUN chmod +x /opt/microsoft/powershell/7/pwsh
2828
RUN ln -s /opt/microsoft/powershell/7/pwsh /usr/bin/pwsh
2929
# end of install powershell
3030

31-
FROM mcr.microsoft.com/dotnet/sdk:8.0-alpine AS build
31+
FROM mcr.microsoft.com/dotnet/sdk:9.0-alpine AS build
3232
WORKDIR /markdown-link-check-log-parser
3333
COPY ["MarkdownLinkCheckLogParser/NuGet.Config", "MarkdownLinkCheckLogParser/"]
3434
COPY ["MarkdownLinkCheckLogParser/src/MarkdownLinkCheckLogParserCli/MarkdownLinkCheckLogParserCli.csproj", "MarkdownLinkCheckLogParser/src/MarkdownLinkCheckLogParserCli/"]

MarkdownLinkCheckLogParser/.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ dotnet_diagnostic.CA1303.severity = none # CA1303: Do not pass literals a
9696
dotnet_diagnostic.CA1308.severity = none # CA1308: Normalize strings to uppercase
9797
# Maintainability rules https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/maintainability-warnings
9898
dotnet_diagnostic.CA1508.severity = none # CA1508: Avoid dead conditional code # This one seems to flag false positives in some cases
99+
dotnet_diagnostic.CA1515.severity = none # CA1515: Consider making public types internal # As of writing this there are several open issues about this rule but this one seems to sum the problem https://github.com/dotnet/roslyn-analyzers/issues/7192. Other issues: https://github.com/dotnet/roslyn-analyzers/issues?q=ca1515
99100
# Naming rules https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/naming-warnings
100101
dotnet_diagnostic.CA1711.severity = none # CA1711: Identifiers should not have incorrect suffix
101102
# Reliability rules https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/reliability-warnings

MarkdownLinkCheckLogParser/global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "8.0.x",
3+
"version": "9.0.x",
44
"rollForward": "disable",
55
"allowPrerelease": false
66
}

MarkdownLinkCheckLogParser/src/MarkdownLinkCheckLogParserCli/MarkdownLinkCheckLogParserCli.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFramework>net8.0</TargetFramework>
5+
<TargetFramework>net9.0</TargetFramework>
66
</PropertyGroup>
77

88
<ItemGroup>

MarkdownLinkCheckLogParser/tests/MarkdownLinkCheckLogParserCli.Tests/MarkdownLinkCheckLogParserCli.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net8.0</TargetFramework>
4+
<TargetFramework>net9.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66
<IsTestProject>true</IsTestProject> <!-- This shouldn't be needed because it should be added by the Microsoft.NET.Test.Sdk package but for now it's required as explained here https://github.com/dotnet/sdk/issues/3790#issuecomment-1100773198 -->
77
</PropertyGroup>

0 commit comments

Comments
 (0)