Add APM agent configuration #1196
Open
+1,295
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimuon
reviewed
Jul 15, 2025
dimuon
reviewed
Jul 15, 2025
dimuon
reviewed
Jul 15, 2025
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccResourceAgentConfigurationCreate(serviceName), | ||
| Check: resource.ComposeTestCheckFunc( |
There was a problem hiding this comment.
IMO it makes sense to check id too.
dimuon
reviewed
Jul 15, 2025
| tflog.Trace(ctx, fmt.Sprintf("Created APM agent configuration with ID: %s", id)) | ||
|
|
||
| resp.Diagnostics.Append(resp.State.Set(ctx, &plan)...) | ||
| } |
There was a problem hiding this comment.
I think some resources in this provider (maybe ones based on SDKv2) call read in scope of create/update calls but it seems we don't use this pattern here. IIRC, the EC provider also calls read inside create/update calls. Does it make sense to do this here too?
dimuon
reviewed
Jul 15, 2025
dimuon
reviewed
Jul 15, 2025
Co-authored-by: Dmitry Onishchenko <8962171+dimuon@users.noreply.github.com>
dimuon
reviewed
Jul 18, 2025
dimuon
reviewed
Jul 18, 2025
Co-authored-by: Dmitry Onishchenko <8962171+dimuon@users.noreply.github.com>
The fix has been merged into Kibana/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315
A couple of things:
transform_schemawhich I don't really want to add to unless it's strictly required. When these endpoints are eventually moved to the automatically generated schema (as opposed to the hand crafted one in use today), the existing code handling this header will kick in and we can tidy it up.