review fixes

Author: lud

lib/ex_doc/formatter/epub/templates.ex

@@ -16,8 +16,7 @@ defmodule ExDoc.Formatter.EPUB.Templates do
   Generate content from the module template for a given `node`
   """
   def module_page(config, module_node) do
-    summary = H.module_summary(module_node)
-    module_template(config, module_node, summary)
+    module_template(config, module_node)
   end
 
   @doc """
@@ -53,7 +52,7 @@ defmodule ExDoc.Formatter.EPUB.Templates do
     :def,
     :module_template,
     Path.expand("templates/module_template.eex", __DIR__),
-    [:config, :module, :summary],
+    [:config, :module],
     trim: true
   )
 

lib/ex_doc/formatter/epub/templates/module_template.eex

@@ -15,14 +15,14 @@
       </section>
     <% end %>
 
-    <%= if summary != [] do %>
+    <%= if module.docs_groups != [] do %>
       <section id="summary" class="details-list">
         <h1 class="section-heading">Summary</h1>
-        <%= for group <- summary, do: H.summary_template(group.title, group.docs) %>
+        <%= for group <- module.docs_groups, do: H.summary_template(group.title, group.docs) %>
       </section>
     <% end %>
 
-    <%= for group <- summary, key = text_to_id(group.title) do %>
+    <%= for group <- module.docs_groups, key = text_to_id(group.title) do %>
       <section id="<%= key %>" class="details-list">
         <h1 class="section-heading"><%=h to_string(group.title) %></h1>
         <%= if doc = group.doc  do %>

lib/ex_doc/formatter/html/assets.ex

@@ -7,7 +7,7 @@ defmodule ExDoc.Formatter.HTML.Assets do
     |> Path.wildcard()
     |> Enum.map(fn path ->
       Module.put_attribute(__CALLER__.module, :external_resource, path)
-      {Path.basename(path), "File.read!(#{path})"}
+      {Path.basename(path), File.read!(path)}
     end)
   end
 

lib/ex_doc/formatter/html/templates.ex

@@ -16,8 +16,7 @@ defmodule ExDoc.Formatter.HTML.Templates do
   Generate content from the module template for a given `node`
   """
   def module_page(module_node, config) do
-    summary = module_summary(module_node)
-    module_template(config, module_node, summary)
+    module_template(config, module_node)
   end
 
   @doc """
@@ -99,9 +98,7 @@ defmodule ExDoc.Formatter.HTML.Templates do
     modules =
       for module <- modules do
         groups =
-          module
-          |> module_summary()
-          |> case do
+          case module.docs_groups do
             [] -> []
             entries -> [nodeGroups: Enum.map(entries, &sidebar_entries/1)]
           end
@@ -153,8 +150,6 @@ defmodule ExDoc.Formatter.HTML.Templates do
     end)
   end
 
-  def module_summary(module_node), do: module_node.docs_groups
-
   defp favicon_path(%{favicon: nil}), do: nil
   defp favicon_path(%{favicon: favicon}), do: "assets/favicon#{Path.extname(favicon)}"
 
@@ -222,7 +217,7 @@ defmodule ExDoc.Formatter.HTML.Templates do
     detail_template: [:node, :module],
     footer_template: [:config, :source_path],
     head_template: [:config, :title, :noindex],
-    module_template: [:config, :module, :summary],
+    module_template: [:config, :module],
     not_found_template: [:config],
     api_reference_entry_template: [:module_node],
     api_reference_template: [:config, :nodes_map],

lib/ex_doc/formatter/html/templates/module_template.eex

@@ -31,19 +31,19 @@
   <% end %>
 </div>
 
-<%= if summary != [] do %>
+<%= if module.docs_groups != [] do %>
   <section id="summary" class="details-list">
     <h1 class="section-heading">
       <a class="hover-link" href="#summary">
         <i class="ri-link-m" aria-hidden="true"></i>
       </a>
       <span class="text">Summary</span>
     </h1>
-    <%= for group <- summary, do: summary_template(group.title, group.docs) %>
+    <%= for group <- module.docs_groups, do: summary_template(group.title, group.docs) %>
   </section>
 <% end %>
 
-<%= for group <- summary, key = text_to_id(group.title) do %>
+<%= for group <- module.docs_groups, key = text_to_id(group.title) do %>
   <section id="<%= key %>" class="details-list">
     <h1 class="section-heading">
       <a class="hover-link" href="#<%= key %>">