Skip to content

functions should not modify input objects #15

@lenarddome

Description

@lenarddome

When running metadpy.mle.metad on a pandas.DataFrame, the function modifies the original DataFrame. I believe this behaviour is unintended and might cause some issues with later data processing.

Specifically, it adds three extra columns: Subject, Within, Between.

A more appropriate way to handle this would be to create a copy of the DataFrame for internal operations of the function and leave the original object untouched.

Use the example I provided to reproduce problem: #13

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions