Skip to content

Commit fa40847

Browse files
committed
Use optimal codesize flags for embind_val test
- `-sDYNAMIC_EXECUTION=0` was no-op since we added it to common flags. - `-fno-rtti` fallback is actually more expensive than the default RTTI-based mode (using actual `typeid(T)`).
1 parent 357a773 commit fa40847

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

test/code_size/embind_val_wasm.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"a.html.gz": 380,
44
"a.js": 5367,
55
"a.js.gz": 2540,
6-
"a.wasm": 9101,
7-
"a.wasm.gz": 4698,
8-
"total": 15020,
9-
"total_gz": 7618
6+
"a.wasm": 7474,
7+
"a.wasm.gz": 3469,
8+
"total": 13393,
9+
"total_gz": 6389
1010
}

test/test_other.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11885,11 +11885,7 @@ def test_minimal_runtime_code_size(self, test_name, wasm2js, compare_js_output=F
1188511885
hello_wasm_worker_sources = [test_file('wasm_worker/wasm_worker_code_size.c'), '-sWASM_WORKERS', '-sENVIRONMENT=web']
1188611886
audio_worklet_sources = [test_file('webaudio/audioworklet.c'), '-sWASM_WORKERS', '-sAUDIO_WORKLET', '-sENVIRONMENT=web', '-sTEXTDECODER=1']
1188711887
embind_hello_sources = [test_file('code_size/embind_hello_world.cpp'), '-lembind']
11888-
embind_val_sources = [test_file('code_size/embind_val_hello_world.cpp'),
11889-
'-lembind',
11890-
'-fno-rtti',
11891-
'-DEMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0',
11892-
'-sDYNAMIC_EXECUTION=0']
11888+
embind_val_sources = [test_file('code_size/embind_val_hello_world.cpp'), '-lembind']
1189311889

1189411890
sources = {
1189511891
'hello_world': hello_world_sources,

0 commit comments

Comments
 (0)