Add CheckMetadataHash signed extension (#373)

* random voting in bot-community

* democracy bot fixes

* fmt

* cosmetics

* add cli export-secret and help tester with the mnemonic of an account which will skip voting. randomize turnout too

* fix ci

* polkadot-v1.13.0; bump api-client and encointer-pallets

* [node] fix build after upgrade

* fix ci

* bump-versions

* bump Cargo.lock

* [runtime] add `CheckMetaDataHash` extension and bump api-client library

* change branch to api-client supporting the check metadata hash extension

* bump api client

* fix benchmarking build

* toml fmt

* [runtime] fix fmt

---------

Co-authored-by: Alain Brenzikofer <alain@integritee.network>

Author: clangenb

Cargo.lock

@@ -51,6 +51,7 @@ pallet-encointer-scheduler = { default-features = false, version = "~12.1.0" }
 frame-benchmarking = { version = "35.0.0", default-features = false }
 frame-benchmarking-cli = { version = "39.0.0" }
 frame-executive = { version = "35.0.0", default-features = false }
+frame-metadata-hash-extension = { version = "0.3.0", default-features = false }
 frame-support = { version = "35.0.0", default-features = false }
 frame-system = { version = "35.0.0", default-features = false }
 frame-system-benchmarking = { version = "35.0.0", default-features = false }
@@ -125,11 +126,11 @@ substrate-client-keystore = { version = "0.10.0" }
 [patch.crates-io]
 ## api client
 # todo: temporary patch until ^0.17.1 is released
-ac-compose-macros = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-sdk-1.13" }
-ac-node-api = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-sdk-1.13" }
-ac-primitives = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-sdk-1.13" }
-substrate-api-client = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-sdk-1.13" }
-substrate-client-keystore = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-sdk-1.13" }
+ac-compose-macros = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-check-metadata-hash-sdk-1.13" }
+ac-node-api = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-check-metadata-hash-sdk-1.13" }
+ac-primitives = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-check-metadata-hash-sdk-1.13" }
+substrate-api-client = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-check-metadata-hash-sdk-1.13" }
+substrate-client-keystore = { git = "https://github.com/encointer/substrate-api-client.git", branch = "crates-io-v0.17.0-patch-for-stable-check-metadata-hash-sdk-1.13" }
 #ac-node-api = { path = "../../substrate-api-client/node-api" }
 #ac-primitives = { path = "../../substrate-api-client/primitives" }
 #substrate-api-client = { path = "../../substrate-api-client" }

Cargo.toml

@@ -28,6 +28,7 @@ futures = { workspace = true }
 log = { workspace = true }
 serde_json = { workspace = true }
 
+frame-metadata-hash-extension = { workspace = true, features = ["std"] }
 frame-system = { workspace = true, features = ["std"] }
 pallet-asset-tx-payment = { workspace = true, features = ["std"] }
 sc-cli = { workspace = true }

node/Cargo.toml

@@ -120,6 +120,7 @@ pub fn create_benchmark_extrinsic(
 		frame_system::CheckNonce::<runtime::Runtime>::from(nonce),
 		frame_system::CheckWeight::<runtime::Runtime>::new(),
 		pallet_asset_tx_payment::ChargeAssetTxPayment::<runtime::Runtime>::from(0, None),
+		frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(false),
 	);
 
 	let raw_payload = runtime::SignedPayload::from_raw(
@@ -134,6 +135,7 @@ pub fn create_benchmark_extrinsic(
 			(),
 			(),
 			(),
+			None,
 		),
 	);
 	let signature = raw_payload.using_encoded(|e| sender.sign(e));

node/src/benchmarking.rs

@@ -32,6 +32,7 @@ pallet-encointer-scheduler = { workspace = true }
 
 # substrate deps
 frame-executive = { workspace = true }
+frame-metadata-hash-extension = { workspace = true }
 frame-support = { workspace = true }
 frame-system = { workspace = true }
 pallet-asset-tx-payment = { workspace = true }
@@ -73,7 +74,7 @@ frame-system-benchmarking = { workspace = true, optional = true }
 hex-literal = { workspace = true, optional = true }
 
 [build-dependencies]
-substrate-wasm-builder = { workspace = true }
+substrate-wasm-builder = { workspace = true, optional = true, features = ["metadata-hash"] }
 
 [features]
 default = ["std"]
@@ -83,6 +84,7 @@ std = [
     "encointer-primitives/serde_derive",
     "encointer-primitives/std",
     "frame-executive/std",
+    "frame-metadata-hash-extension/std",
     "frame-support/std",
     "frame-system-rpc-runtime-api/std",
     "frame-system/std",
@@ -124,6 +126,7 @@ std = [
     "sp-std/std",
     "sp-transaction-pool/std",
     "sp-version/std",
+    "substrate-wasm-builder",
 ]
 runtime-benchmarks = [
     "frame-benchmarking/runtime-benchmarks",

runtime/Cargo.toml

@@ -1,9 +1,9 @@
-use substrate_wasm_builder::WasmBuilder;
-
+#[cfg(feature = "std")]
 fn main() {
-	WasmBuilder::new()
-		.with_current_project()
-		.export_heap_base()
-		.import_memory()
+	substrate_wasm_builder::WasmBuilder::init_with_defaults()
+		.enable_metadata_hash("ERT", 12)
 		.build()
 }
+
+#[cfg(not(feature = "std"))]
+fn main() {}

runtime/build.rs

@@ -480,7 +480,7 @@ pub struct NoConversion;
 impl ConversionFromAssetBalance<u128, (), u128> for NoConversion {
 	type Error = ();
 	fn from_asset_balance(balance: Balance, _asset_id: ()) -> Result<Balance, Self::Error> {
-		return Ok(balance)
+		return Ok(balance);
 	}
 	#[cfg(feature = "runtime-benchmarks")]
 	fn ensure_successful(_: ()) {}
@@ -590,6 +590,7 @@ pub type SignedExtra = (
 	frame_system::CheckNonce<Runtime>,
 	frame_system::CheckWeight<Runtime>,
 	pallet_asset_tx_payment::ChargeAssetTxPayment<Runtime>,
+	frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
 );
 /// Unchecked extrinsic type as expected by this runtime.
 pub type UncheckedExtrinsic =