refactor: decouples translators from extproc #1507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
won't merge until v0.4 |
mathetake
force-pushed
the
decoupletranslator
branch
from
f4c6221 to
87a9506
Compare
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> # Conflicts: # internal/extproc/translator/openai_gcpvertexai_test.go
mathetake
force-pushed
the
decoupletranslator
branch
from
312acd9 to
88a53c1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
- Coverage 83.92% 83.78% -0.15%
==========================================
Files 144 143 -1
Lines 12668 12537 -131
==========================================
- Hits 10632 10504 -128
+ Misses 1421 1417 -4
- Partials 615 616 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # internal/extproc/translator/imagegeneration_openai_openai_test.go # internal/extproc/translator/openai_gcpvertexai.go
dosubot
bot
added
the
size:XL
Member
Author
|
Sorry bad merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The translators shouldn't have to be tied with ext_proc APIs since it's none of their concerns. This commit decouples the translator package from them so that we can easily use them in dynamic modules too.
Related Issues/PRs (if applicable)
Preparation for #90