build: use GNU ld instead of gold for GCC build

Gold is deprecated beginning from GNU binutils 2.44.  It is no longer
included in standard binutils release and it is scheduled for complete
removal.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>

Author: tsaarni

.bazelrc

@@ -76,7 +76,7 @@ build:linux --conlyopt=-fexceptions
 build:linux --fission=dbg,opt
 build:linux --features=per_object_debug_info
 build:linux --action_env=BAZEL_LINKLIBS=-l%:libstdc++.a
-build:linux --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=gold
+build:linux --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=bfd
 
 # We already have absl in the build, define absl=1 to tell googletest to use absl for backtrace.
 build --define absl=1
@@ -109,7 +109,7 @@ build:clang-pch --define=ENVOY_CLANG_PCH=1
 build:libstdc++ --@envoy//bazel:libc++=false
 build:libstdc++ --@envoy//bazel:libstdc++=true
 
-# Use gold linker for gcc compiler.
+# Gcc with libstdc++
 build:gcc --config=libstdc++
 build:gcc --test_env=HEAPCHECK=
 build:gcc --action_env=BAZEL_COMPILER=gcc
@@ -127,7 +127,7 @@ build:gcc --cxxopt=-Wno-missing-requires
 build:gcc --cxxopt=-Wno-dangling-reference
 build:gcc --cxxopt=-Wno-nonnull-compare
 build:gcc --incompatible_enable_cc_toolchain_resolution=false
-build:gcc --linkopt=-fuse-ld=gold --host_linkopt=-fuse-ld=gold
+build:gcc --linkopt=-fuse-ld=bfd --host_linkopt=-fuse-ld=bfd
 
 # Clang-tidy
 # TODO(phlax): enable this, its throwing some errors as well as finding more issues

bazel/rbe/toolchains/configs/linux/gcc/cc/BUILD

@@ -101,13 +101,12 @@ cc_toolchain_config(
     dbg_compile_flags = ["-g"],
     host_system_name = "local",
     link_flags = [
-        "-fuse-ld=lld",
+        "-fuse-ld=bfd",
         "-Wl,-no-as-needed",
         "-Wl,-z,relro,-z,now",
         "-B/usr/bin",
         "-pass-exit-codes",
         "-lm",
-        "-fuse-ld=gold",
     ],
     link_libs = ["-l:libstdc++.a"],
     opt_compile_flags = [
@@ -119,7 +118,7 @@ cc_toolchain_config(
         "-fdata-sections",
     ],
     opt_link_flags = ["-Wl,--gc-sections"],
-    supports_start_end_lib = True,
+    supports_start_end_lib = False,
     target_libc = "local",
     target_system_name = "local",
     tool_paths = {

bazel/rbe/toolchains/configs/linux/gcc/cc/cc_toolchain_config.bzl

@@ -820,13 +820,6 @@ def _impl(ctx):
                     flag_group(
                         iterate_over = "libraries_to_link",
                         flag_groups = [
-                            flag_group(
-                                flags = ["-Wl,--start-lib"],
-                                expand_if_equal = variable_with_value(
-                                    name = "libraries_to_link.type",
-                                    value = "object_file_group",
-                                ),
-                            ),
                             flag_group(
                                 flags = ["-Wl,-whole-archive"],
                                 expand_if_true =
@@ -879,13 +872,6 @@ def _impl(ctx):
                                 flags = ["-Wl,-no-whole-archive"],
                                 expand_if_true = "libraries_to_link.is_whole_archive",
                             ),
-                            flag_group(
-                                flags = ["-Wl,--end-lib"],
-                                expand_if_equal = variable_with_value(
-                                    name = "libraries_to_link.type",
-                                    value = "object_file_group",
-                                ),
-                            ),
                         ],
                         expand_if_available = "libraries_to_link",
                     ),

bazel/rbe/toolchains/gcc.env.json

@@ -1,7 +1,7 @@
 {
   "BAZEL_COMPILER": "gcc",
   "BAZEL_LINKLIBS": "-l%:libstdc++.a",
-  "BAZEL_LINKOPTS": "-lm:-fuse-ld=gold",
+  "BAZEL_LINKOPTS": "-lm:-fuse-ld=bfd",
   "CC": "gcc",
   "CXX": "g++",
   "PATH": "/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/llvm/bin"

bazel/rbe/toolchains/rbe_toolchains_config.bzl

@@ -31,7 +31,7 @@ _CLANG_LIBCXX_ENV = dicts.add(_CLANG_ENV, {
 _GCC_ENV = {
     "BAZEL_COMPILER": "gcc",
     "BAZEL_LINKLIBS": "-l%:libstdc++.a",
-    "BAZEL_LINKOPTS": "-lm:-fuse-ld=gold",
+    "BAZEL_LINKOPTS": "-lm:-fuse-ld=bfd",
     "CC": "gcc",
     "CXX": "g++",
     "PATH": "/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/llvm/bin",

changelogs/current.yaml

@@ -94,6 +94,9 @@ minor_behavior_changes:
     Cap the frame size for streamed grpc at 1MB. Without this change there was a small chance
     that if a request streamed in sufficiently faster than it was processed, a frame larger than
     4MB could be encoded, which most upstream grpc services would, by default, treat as an error.
+- area: build
+  change: |
+    GCC build now use GNU ld. The gold linker was deprecated in binutils 2.44.
 
 bug_fixes:
 # *Changes expected to improve the state of the world and are unlikely to have negative effects*