#78 Upgrade metabase to v0.50.36 (#80)

Co-authored-by: Tun Loakthar <thein.loakthar@exasol.com>

Author: kaklakariada

.github/workflows/ci-build.yml

@@ -15,7 +15,7 @@ jobs:
       cancel-in-progress: true
     runs-on: ubuntu-latest
     env:
-      METABASE_TAG: v0.48.0
+      METABASE_TAG: v0.50.36
     steps:
       - name: Checkout the repository
         uses: actions/checkout@v4
@@ -34,24 +34,24 @@ jobs:
       - name: Set up JDK 11
         uses: actions/setup-java@v4
         with:
-          distribution: temurin
+          distribution: 'temurin'
           java-version: 11
 
       - name: Install clojure tools
-        uses: DeLaGuardo/setup-clojure@12.1
+        uses: DeLaGuardo/setup-clojure@13.4
         with:
           cli: '1.11.1.1262'
 
       - name: Cache Maven repository
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('metabase-driver/deps.edn', 'metabase/**/deps.edn') }}
           restore-keys: |
             ${{ runner.os }}-maven-
 
       - name: Cache clj-kondo
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: metabase-driver/.clj-kondo/.cache
           key: clj-kondo-cache-${{ hashFiles('metabase-driver/deps.edn') }}
@@ -62,6 +62,7 @@ jobs:
         run: |
           java --version
           echo Clojure: $(clojure -M --eval "(clojure-version)")
+          clojure -M --eval '(println "Java" (System/getProperty "java.version") "Clojure" (clojure-version))'
           clojure --version
           cd metabase-driver && clojure -M:clj-kondo --version
 

.github/workflows/integration-tests.yml

@@ -11,14 +11,15 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        exasol_version: ["7.1.17", "8.18.1"] # Must be supported by integration-test-docker-environment
+        exasol_version: ["7.1.30", "8.34.0"] # Must be supported by integration-test-docker-environment
+        # See https://github.com/exasol/integration-test-docker-environment/tree/main/docker_db_config_template
     concurrency:
       group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.exasol_version }}
       cancel-in-progress: true
     name: "Build with Exasol ${{ matrix.exasol_version }}"
     runs-on: ubuntu-latest
     env:
-      METABASE_TAG: v0.48.0
+      METABASE_TAG: v0.50.36
     steps:
       - name: Free Disk Space
         run: |
@@ -43,7 +44,7 @@ jobs:
         with:
           fetch-depth: 1
           repository: 'exasol/integration-test-docker-environment'
-          ref: "2.0.0"
+          ref: "4.2.0"
           path: 'integration-test-docker-environment'
 
       - name: Set up JDK 11
@@ -53,20 +54,20 @@ jobs:
           java-version: 11
 
       - name: Install clojure tools
-        uses: DeLaGuardo/setup-clojure@12.1
+        uses: DeLaGuardo/setup-clojure@13.4
         with:
           cli: '1.11.1.1262'
 
       - name: Cache Maven repository
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('metabase-driver/deps.edn', 'metabase-driver/scripts/run-integration-tests.sh', 'metabase/**/deps.edn') }}
           restore-keys: |
             ${{ runner.os }}-maven-
 
       - name: Cache node modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
@@ -78,6 +79,7 @@ jobs:
           java --version
           echo Clojure: $(clojure -M --eval "(clojure-version)")
           clojure --version
+          clojure -M --eval '(println "Java" (System/getProperty "java.version") "Clojure" (clojure-version))'
 
       - name: Build Metabase static viz
         run: |

.github/workflows/release_droid_upload_github_release_assets.yml

@@ -11,7 +11,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     env:
-      METABASE_TAG: v0.48.0
+      METABASE_TAG: v0.50.36
     steps:
       - name: Checkout the repository
         uses: actions/checkout@v4
@@ -30,16 +30,16 @@ jobs:
       - name: Set up JDK 11
         uses: actions/setup-java@v4
         with:
-          distribution: temurin
+          distribution: 'temurin'
           java-version: 11
 
       - name: Install clojure tools
-        uses: DeLaGuardo/setup-clojure@12.1
+        uses: DeLaGuardo/setup-clojure@13.4
         with:
           cli: '1.11.1.1262'
 
       - name: Cache Maven repository
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('metabase-driver/deps.edn', 'metabase/**/deps.edn') }}
@@ -51,6 +51,7 @@ jobs:
           java --version
           echo Clojure: $(clojure -M --eval "(clojure-version)")
           clojure --version
+          clojure -M --eval '(println "Java" (System/getProperty "java.version") "Clojure" (clojure-version))'
 
       - name: Build driver
         run: "$GITHUB_WORKSPACE/metabase-driver/scripts/build.sh"

SECURITY.md

@@ -0,0 +1,26 @@
+# Security
+
+If you believe you have found a new security vulnerability in this repository, please report it to us as follows.
+
+## Reporting Security Issues
+
+* Please do **not** report security vulnerabilities through public GitHub issues.
+
+* Please create a draft security advisory on the Github page: the reporting form is under `> Security > Advisories`. The URL is https://github.com/exasol/metabase-driver/security/advisories/new.
+
+* If you prefer to email, please send your report to `infosec@exasol.com`.
+
+## Guidelines 
+
+* When reporting a vulnerability, please include as much information as possible, including the complete steps to reproduce the issue. 
+
+* Avoid sending us executables.
+
+* Feel free to include any script you wrote and used but avoid sending us scripts that download and run binaries. 
+
+* We will prioritise reports that show how the exploits work in realistic environments. 
+
+* We prefer all communications to be in English. 
+
+* We do not offer financial rewards. We are happy to acknowledge your research publicly when possible. 
+

deps.edn

@@ -11,9 +11,9 @@
  :aliases
  {:dev
   {:extra-deps
-   {io.github.metabase/metabase {:git/tag "v0.48.0" :git/sha "0ca7df3"}}}
+   {io.github.metabase/metabase {:git/tag "v0.50.36" :git/sha "0ca7df3"}}}
 
   ; clojure -M:clj-kondo --lint src test --debug
   :clj-kondo
-  {:replace-deps {clj-kondo/clj-kondo {:mvn/version "2023.10.20"}}
+  {:replace-deps {clj-kondo/clj-kondo {:mvn/version "2025.07.28"}}
    :main-opts ["-m" "clj-kondo.main"]}}}

doc/changes/changelog.md

@@ -1,5 +1,6 @@
 # Changes
 
+* [1.0.8](changes_1.0.8.md)
 * [1.0.7](changes_1.0.7.md)
 * [1.0.6](changes_1.0.6.md)
 * [1.0.5](changes_1.0.5.md)

doc/changes/changes_1.0.8.md

@@ -0,0 +1,13 @@
+# metabase-driver 1.0.8, released 2025-08-01
+
+Code name: Upgrade to Metabase v0.50.36
+
+## Summary
+
+This release adapts the driver to Metabase v0.50.36.
+
+The driver now supports Metabase feature `:describe-fks`. This allows Metabase to retrieve metadata about Foreign Key Constraints from Exasol.
+
+## Features
+
+* #78: Upgraded to Metabase v0.50.36

doc/developer_guide/developer_guide.md

@@ -36,24 +36,35 @@ clojure -M --eval "(clojure-version)"
 clojure --version
 ```
 
+### Verify Correct Java Version
+
+Metabase uses Java 11 by default. Check which Java version is used by Clojure:
+
+```sh
+clojure -M --eval '(println "Java" (System/getProperty "java.version") "Clojure" (clojure-version))'
+# Only major java version:
+clojure -M --eval '(println (. (Runtime/version) major))'
+```
+
+If this reports another Java version, update `JAVA_HOME` and check again.
+
 ## Setup Development Environment
 
 1. Checkout Metabase at `$HOME/git/metabase` (= `$METABASE_DIR`) and build it:
 
     ```sh
-    cd $HOME/git
-    git clone https://github.com/metabase/metabase.git
-    cd metabase
-    git fetch --all --tags
-    export METABASE_VERSION=v0.48.0
-    git reset --hard
-    rm -vf target/patch_excluded_test_applied
-    git checkout "tags/${METABASE_VERSION}" -b "${METABASE_VERSION}-branch"
+    export METABASE_DIR=$HOME/git/metabase
+    export METABASE_VERSION=v0.50.36
+    git clone https://github.com/metabase/metabase.git $METABASE_DIR
+    git -C $METABASE_DIR fetch --all --tags
+    git -C $METABASE_DIR reset --hard
+    rm -vf $METABASE_DIR/target/patch_excluded_test_applied
+    git -C $METABASE_DIR checkout "tags/${METABASE_VERSION}" -b "${METABASE_VERSION}-branch"
     # Build (this will take ~15min)
-    ./bin/build.sh
+    $METABASE_DIR/bin/build.sh
     ```
 
-2. Download the Exasol JDBC driver from the [Download Portal](https://downloads.exasol.com/clients-and-drivers) and install it:
+2. Download the Exasol JDBC driver from the [Download Portal](https://downloads.exasol.com/clients-and-drivers) or get it from `~/.m2/repository/com/exasol/exasol-jdbc/$v/exasol-jdbc-$v.jar` and install it:
 
     ```sh
     cp exajdbc.jar "$METABASE_DIR/plugins"
@@ -119,7 +130,7 @@ export METABASE_EXASOL_DRIVER="$HOME/git/metabase-driver"
 cd $METABASE_EXASOL_DRIVER
 
 # Build driver
-clojure -X:build :project-dir "\"$(pwd)\""
+./scripts/build.sh
 
 # Install driver
 cp -v "$METABASE_EXASOL_DRIVER/target/exasol.metabase-driver.jar" "$METABASE_DIR/plugins/"
@@ -131,13 +142,21 @@ clojure -M:run
 
 ## Running Integration Tests
 
-You need to have metabase checked out next to this repository.
+### Preconditions
 
-Start Exasol docker container:
+* You need to have metabase checked out next to this repository.
 
-```sh
-docker run --publish 8563:8563 --publish 2580:2580 --publish 443:443 --detach --privileged --stop-timeout 120 exasol/docker-db:7.1.23
-```
+* Start Exasol docker container:
+   ```sh
+   docker run --publish 8563:8563 --publish 2580:2580 --publish 443:443 --detach --privileged --stop-timeout 120 exasol/docker-db:8.34.0
+   ```
+
+* Build frontend code required for running integration tests:
+   ```sh
+   cd $METABASE_DIR && yarn build-static-viz
+   ```
+
+### Running
 
 Start integration tests:
 
@@ -150,10 +169,18 @@ This script builds and installs the driver before running the integration tests.
 To run only a single tests or only tests in a namespace add arguments:
 
 ```sh
+# Run single test
 ./scripts/run-integration-tests.sh :only name.space/single-test
+# Run all tests in a name space
 ./scripts/run-integration-tests.sh :only name.space
+# Run tests from multiple namespaces
+./scripts/run-integration-tests.sh :only "[name.space1 name.space2]"
 ```
 
+### Evaluating Test Results
+
+When tests fail locally or in CI, search the log output for `ERROR in` or `FAIL in` to find test errors/failures.
+
 ### Using the REPL
 
 ```sh
@@ -208,34 +235,49 @@ Script `run-integration-tests.sh` automatically applies this patch when file `$M
 When the patch file has changed or you updated to a new Metabase release, do the following and re-run the integration tests with `run-integration-tests.sh`.
 
 ```sh
-cd $METABASE_DIR
-git reset --hard && rm -vf target/patch_excluded_test_applied
+export METABASE_DIR="$HOME/git/metabase"
+git -C $METABASE_DIR reset --hard && rm -fv $METABASE_DIR/target/patch_excluded_test_applied
 ```
 
 #### Applying Patch Fails
 
 If applying the patch fails after upgrading to a new Metabase version, follow these steps:
 
-1. Run `cd $METABASE_DIR && git reset --hard && rm -vf target/patch_excluded_test_applied`
-2. Remove the failed part from `exclude_tests.diff`
-3. Run integration tests `run-integration-tests.sh`. This will apply the patch.
-4. Modify Metabase tests to adapt them to Exasol
-5. Update patch by running `cd $METABASE_DIR && git diff > $METABASE_EXASOL_DRIVER/scripts/exclude_tests.diff`
+1. Run `export METABASE_DIR="$HOME/git/metabase" && export METABASE_EXASOL_DRIVER="$HOME/git/metabase-driver"`
+2. Run `git -C $METABASE_DIR reset --hard && rm -vf $METABASE_DIR/target/patch_excluded_test_applied`
+3. Remove the failed part from `exclude_tests.diff`
+4. Run integration tests `run-integration-tests.sh`. This will apply the patch.
+5. Modify Metabase tests to adapt them to Exasol
+6. Update patch by running `git -C $METABASE_DIR diff > $METABASE_EXASOL_DRIVER/scripts/exclude_tests.diff`
 
 ## Linting
 
 ```sh
 clojure -M:clj-kondo --lint src test --debug
 ```
 
-# Troubleshooting
+# Building a Release
 
-## `FileNotFoundException: Could not locate metabase/test/data/exasol__init.class, metabase/test/data/exasol.clj or metabase/test/data/exasol.cljc on classpath.`
+Releases are built using [release-droid](https://github.com/exasol/release-droid).
 
-Verify that `$METABASE_DIR/modules/drivers/exasol` is a symlink to the `metabase-driver` directory.
+# Troubleshooting
 
 ## Failing Integration Tests
 
+### Error `Javascript resource not found`
+
+Tests fail with the following error
+
+```
+Javascript resource not found: frontend_client/app/dist/lib-static-viz.bundle.js
+```
+
+then run
+
+```sh
+cd $METABASE_DIR && yarn build-static-viz
+```
+
 ### Different Decimal Point
 
 Tests fail on macOS because they expect numbers with a `.` as decimal point (e.g. `1000.0 µs`) but get a `,` (e.g. `1000,0 µs`), e.g.:
@@ -253,3 +295,33 @@ Solution: run tests under Linux with English locale or pass arguments `-J-Duser.
 ### Time Dependent Tests
 
 Some Metabase integration tests depend on the current timestamp and will fail when the year changes. See [issue #14](https://github.com/exasol/metabase-driver/issues/14) for details.
+
+### Inconsistent Test Results in CI and Locally
+
+If a tests fails in CI and succeeds locally or vice versa, ensure you have a clean working copy of `$METABASE_DIR`:
+
+```sh
+export METABASE_DIR="$HOME/git/metabase"
+git -C $METABASE_DIR clean --no-quiet --force -d -x
+# Rebuild UI, required by integration tests.
+cd $METABASE_DIR && yarn build-static-viz
+```
+
+This will delete all ignored files.
+
+## Timeout During Build of Metabase
+
+Metabase build using script `./bin/build.sh` fails with a timeout in `yarn`:
+
+```
+...
+        Step "$ \"yarn\"" failed with error "Timed out after 900000 ms."
+What would you like to do?
+[T]ry this step again
+[F]ail -- pass the failure of this step to the parent step (which can be retried)
+[S]kip this step
+[R]EPL -- open a REPL so you can debug things
+[Q]uit the build script (or return to the top level if running from the REPL) [T/F/S/R/Q] t
+```
+
+Type `t` to try again. It should work at a second try.