#121: Fixed Github release (#122)

Author: tomuben

.github/workflows/build-and-publish.yml

@@ -22,8 +22,8 @@ jobs:
       - name: Build Artifacts
         run: poetry build
 
-      - name: PyPi Release
-        env:
-          POETRY_HTTP_BASIC_PYPI_USERNAME: "__token__"
-          POETRY_HTTP_BASIC_PYPI_PASSWORD: "${{ secrets.PYPI_TOKEN }}"
-        run: poetry publish
+#      - name: PyPi Release
+#        env:
+#          POETRY_HTTP_BASIC_PYPI_USERNAME: "__token__"
+#          POETRY_HTTP_BASIC_PYPI_PASSWORD: "${{ secrets.PYPI_TOKEN }}"
+#        run: poetry publish

.github/workflows/slc_cd.yml

@@ -24,7 +24,3 @@ Besides, it updates dependencies and fixes some bugs.
  - #111: Create new templates for Github Workflows - tests
  - #114: Addeed command for deploying cd workflows
  - #116: Added CD workflows
-
-## Bugs
-
- - #119: Fixed Github release

.github/workflows/slc_ci_build_slc.yml

@@ -1,6 +1,16 @@
 # Unreleased
 
+This hotfix fixes the Github release workflows and avoids leakage of passwords in log artifacts.
+
 ## Refactorings
 
  - #125: Updated exaslct and added check for password leak
  - #127: Reformatted code with latest PTB
+
+This hotfix fixes the Github release workflows.
+
+
+## Bugs
+
+ - #119: Fixed Github release
+ - #121: Fixed Github release

.github/workflows/slc_ci_check_for_build.yml

@@ -6,6 +6,10 @@ on:
   push:
     tags:
       - '**'
+
+env:
+  RELEASE_NAME: "SLC-${{ github.ref_name }}"
+
 jobs:
   prepare-test-container:
     uses: ./.github/workflows/slc_ci_prepare_test_container.yml
@@ -41,25 +45,47 @@ jobs:
     name: Create Github release
     runs-on: ubuntu-24.04
     steps:
-      - name: Download SLCs
-        id: download-slcs
-        uses: actions/download-artifact@v4
-        with:
-          pattern: slc-*-release
-          path: "slc"
-          merge-multiple: true
+      - name: SCM Checkout
+        uses: actions/checkout@v4
 
       - name: Download Logs
         id: download-logs
         uses: actions/download-artifact@v4
         with:
-          pattern: logs-*
-          merge-multiple: true
+          pattern: logs_*
+          merge-multiple: false
           path: "logs"
 
+      - name: Zip logs
+        run: zip -r logs.zip logs
+
       - name: GitHub Release
         run: >
-          gh release create "SLC-${GITHUB_REF_NAME}"
+          gh release create "$RELEASE_NAME"
           --title "SLC ${GITHUB_REF_NAME}"
           --notes-file "./doc/changes/changes_${GITHUB_REF_NAME}.md"
-          slc/* logs/*{% endraw %}
+          --draft
+          logs.zip
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  upload-release-slc:
+    needs: [get-flavors, cd]
+    runs-on: ubuntu-24.04
+    strategy:
+      fail-fast: true
+      matrix:
+        flavor: ${{fromJson(needs.get-flavors.outputs.matrix)}}
+    steps:
+      - name: SCM Checkout
+        uses: actions/checkout@v4
+      - name: Download SLC
+        id: download-slc
+        uses: actions/download-artifact@v4
+        with:
+          name: slc-${{matrix.flavor}}-release
+          path: "slc"
+      - name: Upload to release
+        run: gh release upload "$RELEASE_NAME" slc/*
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}{% endraw %}

.github/workflows/slc_ci_prepare_test_container.yml

@@ -63,7 +63,7 @@ jobs:
         env:
           DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
           DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
-          BRANCH_NAME: ${{github.head_ref || github.ref_name}}
+          BRANCH_NAME: ${{github.head_ref || github.ref}}
           COMMIT_SHA: ${{github.sha}}
           FLAVOR: ${{inputs.flavor}}
 
@@ -74,11 +74,11 @@ jobs:
         if: ${{ always() }}
         name: Upload log artifacts
         with:
-          name: logs_${{inputs.flavor}}
+          name: logs_build_${{inputs.flavor}}
           path: |
             .build_output/jobs/**/*
             .build_output/security_scan/**/*
-            .build_output/metadata/**/*
+            .build_output/meta_data/**/*
           retention-days: 30
 
       - uses: actions/upload-artifact@v4