Skip to content

Commit 159ba99

Browse files
authored
#55 Replace slf4j with jul (#59)
1 parent 826d95a commit 159ba99

File tree

5 files changed

+21
-24
lines changed

5 files changed

+21
-24
lines changed

doc/changes/changelog.md

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changes_0.6.10.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Udf Debugging Java 0.6.10, released 2023-??-??
2+
3+
Code name: Reduce dependencies
4+
5+
## Summary
6+
7+
This release replaces code that causes an unnecessary dependency on slf4j-api.
8+
9+
## Refactoring
10+
11+
* #55: Replaced code using `slf4j-api`

pk_generated_parent.pom

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pom.xml

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,14 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66
<artifactId>udf-debugging-java</artifactId>
7-
<version>0.6.9</version>
7+
<version>0.6.10</version>
88
<name>udf-debugging-java</name>
99
<description>Utilities for debugging, profiling and code coverage measure for UDFs.</description>
1010
<url>https://github.com/exasol/udf-debugging-java/</url>
1111
<properties>
1212
<junit.version>5.9.3</junit.version>
1313
<jacoco.version>0.8.10</jacoco.version>
1414
</properties>
15-
<distributionManagement>
16-
<snapshotRepository>
17-
<id>ossrh</id>
18-
<url>https://oss.sonatype.org/content/repositories/snapshots</url>
19-
</snapshotRepository>
20-
<repository>
21-
<id>ossrh</id>
22-
<url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
23-
</repository>
24-
</distributionManagement>
2515
<dependencies>
2616
<dependency>
2717
<groupId>jakarta.json</groupId>
@@ -98,8 +88,7 @@
9888
<version>1.3</version>
9989
<scope>test</scope>
10090
</dependency>
101-
<!--Integration
102-
test dependencies-->
91+
<!--Integration test dependencies-->
10392
<dependency>
10493
<groupId>com.exasol</groupId>
10594
<artifactId>exasol-testcontainers</artifactId>
@@ -183,7 +172,7 @@
183172
<parent>
184173
<artifactId>udf-debugging-java-generated-parent</artifactId>
185174
<groupId>com.exasol</groupId>
186-
<version>0.6.9</version>
175+
<version>0.6.10</version>
187176
<relativePath>pk_generated_parent.pom</relativePath>
188177
</parent>
189178
</project>

src/main/java/com/exasol/udfdebugging/UdfTestSetup.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22

33
import java.sql.Connection;
44
import java.util.List;
5+
import java.util.logging.Logger;
56
import java.util.stream.Collectors;
67

7-
import org.slf4j.Logger;
8-
import org.slf4j.LoggerFactory;
9-
108
import com.exasol.bucketfs.Bucket;
119
import com.exasol.exasoltestsetup.ExasolTestSetup;
1210
import com.exasol.udfdebugging.modules.coverage.CoverageModuleFactory;
@@ -20,7 +18,7 @@
2018
public class UdfTestSetup implements AutoCloseable {
2119
private static final List<ModuleFactory> AVAILABLE_MODULES = List.of(new DebuggingModuleFactory(),
2220
new CoverageModuleFactory(), new JProfilerModuleFactory(), new UdfLogsModuleFactory());
23-
private static final Logger LOGGER = LoggerFactory.getLogger(UdfTestSetup.class);
21+
private static final Logger LOGGER = Logger.getLogger(UdfTestSetup.class.getName());
2422
private final List<Module> enabledModules;
2523

2624
/**
@@ -69,15 +67,13 @@ public String[] getJvmOptions() {
6967
}
7068

7169
private void printInfoMessage() {
72-
if (LOGGER.isInfoEnabled()) {
73-
LOGGER.info(getInfoMessage());
74-
}
70+
LOGGER.info(this::getInfoMessage);
7571
}
7672

7773
private String getInfoMessage() {
78-
return AVAILABLE_MODULES.stream()
74+
return "UDF debug config: " + AVAILABLE_MODULES.stream()
7975
.map(module -> module.getModulePropertyName() + ": " + (module.isEnabled() ? "✓" : "✗"))
80-
.collect(Collectors.joining("; ")) + "\n";
76+
.collect(Collectors.joining("; "));
8177
}
8278

8379
@Override

0 commit comments

Comments
 (0)