Fix bug in client pool cache population.

osery · osery · commit a5f49b527279 · 2022-09-30T15:20:37.000+02:00
diff --git a/pkg/gonvif/pool.go b/pkg/gonvif/pool.go
@@ -65,9 +65,10 @@ func (p *pool) newClientSynced(k key) (Client, error) {
 func (p *pool) newClient(k key) (Client, error) {
 	client, err := New(k.baseURL, k.username, k.password, k.verbose)
 	if err != nil {
-		p.cache.Set(k, client, ttlcache.DefaultTTL)
+		return nil, err
 	}
-	return client, err
+	p.cache.Set(k, client, ttlcache.DefaultTTL)
+	return client, nil
 }
 
 var escaper = strings.NewReplacer(

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,10 @@ func (p *pool) newClientSynced(k key) (Client, error) {`
`65`	`65`	`func (p *pool) newClient(k key) (Client, error) {`
`66`	`66`	`client, err := New(k.baseURL, k.username, k.password, k.verbose)`
`67`	`67`	`if err != nil {`
`68`		`- p.cache.Set(k, client, ttlcache.DefaultTTL)`
	`68`	`+ return nil, err`
`69`	`69`	`}`
`70`		`- return client, err`
	`70`	`+ p.cache.Set(k, client, ttlcache.DefaultTTL)`
	`71`	`+ return client, nil`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`var escaper = strings.NewReplacer(`