Skip to content

Remove deprecated Python versions #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdorsman opened this issue Apr 23, 2025 · 6 comments
Open

Remove deprecated Python versions #433

cdorsman opened this issue Apr 23, 2025 · 6 comments

Comments

@cdorsman
Copy link
Contributor

There are multiple references to Python versions that are officially EOL. And there is no support for newer versions yet.

@faif
Copy link
Owner

faif commented Apr 25, 2025

Hi. Where are the references to specific versions? In the linter?

@cdorsman
Copy link
Contributor Author

cdorsman commented Apr 25, 2025

From the files I found:

python-patterns/blob/master/setup.cfg
python-patterns/blob/master/setup.py (Python 2 and 2.7 is even mentioned)
python-patterns/blob/master/.travis.yml
python-patterns/blob/master/lint.sh
python-patterns/blob/master/tox.ini

According to https://devguide.python.org/versions 3.8 is already deprecated and 3.9 is later this year.

@faif
Copy link
Owner

faif commented Apr 25, 2025

Good catch, thanks. Feel free to create a pull request to address this.

@cdorsman
Copy link
Contributor Author

cdorsman commented Apr 25, 2025

Wel. I would love to. But.

It didn't occur to me at first, but there are two things I want to point out:

  • In the README there is something like "2.7" compatibility flag. Is this still a thing?

If not. It will means that the patterns need to be checked as well if this flag is still defined.

  • The possibility to replace setup.* with pyproject.toml.
    Bring the project right more up-to-date

I can still remove the old 3.8 and 3.9 out and include 3.10 to 3.13.

@faif
Copy link
Owner

faif commented May 2, 2025

There's no need for backwards compatibility. People who really want 2.x compatible code can checkout the legacy branch. Replacing the older with newer versions sounds good

@cdorsman
Copy link
Contributor Author

cdorsman commented May 3, 2025

I have added a PR for solving the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants