fix(bloc_lint): ignore whitespace in ignore comments (#4648)

Author: felangel

packages/bloc_lint/lib/src/text_document.dart

@@ -19,12 +19,14 @@ class TextDocument {
       _content = content;
 
   static final _ignoreForFileRegExp = RegExp(
-    r'^//\s*ignore_for_file:(.*?)$',
+    r'^\s*//\s*ignore_for_file:(.*?)$',
     dotAll: true,
     multiLine: true,
   );
 
-  static final _ignoreForLineRegExp = RegExp(r'^//\s*ignore:(.*)$');
+  static final _ignoreForLineRegExp = RegExp(r'^\s*//\s*ignore:(.*)$');
+
+  static final _ignoreAfterLineRegExp = RegExp(r'\s*//\s*ignore:(.*)$');
 
   final Uri _uri;
   final String _content;
@@ -62,7 +64,7 @@ class TextDocument {
         end: Position(character: _content.length, line: range.end.line),
       ),
     );
-    final index = afterText.indexOf('// ignore:');
+    final index = afterText.indexOf(_ignoreAfterLineRegExp);
     if (index == -1) return const <String>{};
     final line = afterText.substring(index);
     return _lineIgnores(line);

packages/bloc_lint/test/src/linter_test.dart

@@ -127,6 +127,54 @@ bloc:
 import 'package:bloc/bloc.dart';
 import 'package:flutter/material.dart';
 
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+      );
+
+      lintTest(
+        'does not report when rule is ignored for file (w/leading space)',
+        rule: AvoidFlutterImports.new,
+        path: 'counter_bloc.dart',
+        content: '''
+ // ignore_for_file: ${AvoidFlutterImports.rule}
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart';
+
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+      );
+
+      lintTest(
+        'does not report when rule is ignored for file (w/in-between space)',
+        rule: AvoidFlutterImports.new,
+        path: 'counter_bloc.dart',
+        content: '''
+//   ignore_for_file: ${AvoidFlutterImports.rule}
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart';
+
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+      );
+
+      lintTest(
+        'does not report when rule is ignored for file (w/trailing space)',
+        rule: AvoidFlutterImports.new,
+        path: 'counter_bloc.dart',
+        content: '''
+//   ignore_for_file: ${AvoidFlutterImports.rule}  
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart';
+
 enum CounterEvent { increment, decrement }
 class CounterBloc extends Bloc<CounterEvent, int> {
   CounterBloc() : super(0);
@@ -208,6 +256,51 @@ class CounterBloc extends Bloc<CounterEvent, int> {
 import 'package:bloc/bloc.dart';
 import 'package:flutter/material.dart'; // ignore: ${AvoidFlutterImports.rule}
 
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+    );
+
+    lintTest(
+      'does not report when rule is ignored for line (after w/leading space)',
+      rule: AvoidFlutterImports.new,
+      path: 'counter_bloc.dart',
+      content: '''
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart'; //   ignore: ${AvoidFlutterImports.rule}
+
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+    );
+
+    lintTest(
+      'does not report when rule is ignored for line (after w/in-between space)',
+      rule: AvoidFlutterImports.new,
+      path: 'counter_bloc.dart',
+      content: '''
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart'; // ignore:   ${AvoidFlutterImports.rule}
+
+enum CounterEvent { increment, decrement }
+class CounterBloc extends Bloc<CounterEvent, int> {
+  CounterBloc() : super(0);
+}
+''',
+    );
+
+    lintTest(
+      'does not report when rule is ignored for line (after w/trailing space)',
+      rule: AvoidFlutterImports.new,
+      path: 'counter_bloc.dart',
+      content: '''
+import 'package:bloc/bloc.dart';
+import 'package:flutter/material.dart'; // ignore: ${AvoidFlutterImports.rule}  
+
 enum CounterEvent { increment, decrement }
 class CounterBloc extends Bloc<CounterEvent, int> {
   CounterBloc() : super(0);