Skip to content

Commit a57f7d8

Browse files
authored
Code Quality: Fixed the setting name for InfoPane (#16186)
1 parent 2bd5a14 commit a57f7d8

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/Files.App/Data/Contracts/IInfoPaneSettingsService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public interface IInfoPaneSettingsService : IBaseSettingsService, INotifyPropert
1010
/// <summary>
1111
/// Gets or sets a value indicating if the preview pane is enabled.
1212
/// </summary>
13-
bool IsEnabled { get; set; }
13+
bool IsInfoPaneEnabled { get; set; }
1414

1515
/// <summary>
1616
/// Gets or sets a value indicating the height of the pane in a horizontal layout.

src/Files.App/Services/Settings/InfoPaneSettingsService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace Files.App.Services.Settings
55
{
66
internal sealed class InfoPaneSettingsService : BaseObservableJsonSettings, IInfoPaneSettingsService
77
{
8-
public bool IsEnabled
8+
public bool IsInfoPaneEnabled
99
{
1010
get => Get(false);
1111
set => Set(value);

src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public bool IsEnabled
2828
get => isEnabled;
2929
set
3030
{
31-
infoPaneSettingsService.IsEnabled = value;
31+
infoPaneSettingsService.IsInfoPaneEnabled = value;
3232

3333
SetProperty(ref isEnabled, value);
3434
}
@@ -116,7 +116,7 @@ public InfoPaneViewModel()
116116
infoPaneSettingsService.PropertyChanged += PreviewSettingsService_OnPropertyChangedEvent;
117117
contentPageContext.PropertyChanged += ContentPageContext_PropertyChanged;
118118

119-
IsEnabled = infoPaneSettingsService.IsEnabled;
119+
IsEnabled = infoPaneSettingsService.IsInfoPaneEnabled;
120120
}
121121

122122
private async void ContentPageContext_PropertyChanged(object? sender, PropertyChangedEventArgs e)
@@ -429,9 +429,9 @@ private async void PreviewSettingsService_OnPropertyChangedEvent(object? sender,
429429
// The preview will need refreshing as the file details won't be accurate
430430
await UpdateSelectedItemPreviewAsync();
431431
}
432-
else if (e.PropertyName is nameof(infoPaneSettingsService.IsEnabled))
432+
else if (e.PropertyName is nameof(infoPaneSettingsService.IsInfoPaneEnabled))
433433
{
434-
var newEnablingStatus = infoPaneSettingsService.IsEnabled;
434+
var newEnablingStatus = infoPaneSettingsService.IsInfoPaneEnabled;
435435
if (isEnabled != newEnablingStatus)
436436
{
437437
isEnabled = newEnablingStatus;

src/Files.App/Views/MainPage.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ private void UserSettingsService_OnSettingChangedEvent(object? sender, SettingCh
118118
{
119119
switch (e.SettingName)
120120
{
121-
case nameof(IInfoPaneSettingsService.IsEnabled):
121+
case nameof(IInfoPaneSettingsService.IsInfoPaneEnabled):
122122
LoadPaneChanged();
123123
break;
124124
}
@@ -438,7 +438,7 @@ private void LoadPaneChanged()
438438
(MainWindow.Instance.Bounds.Width > 450 && MainWindow.Instance.Bounds.Height > 450 || RootGrid.ActualWidth > 700 && MainWindow.Instance.Bounds.Height > 360);
439439

440440
ViewModel.ShouldPreviewPaneBeDisplayed = (!isHomePage || isMultiPane) && isBigEnough;
441-
ViewModel.ShouldPreviewPaneBeActive = UserSettingsService.InfoPaneSettingsService.IsEnabled && ViewModel.ShouldPreviewPaneBeDisplayed;
441+
ViewModel.ShouldPreviewPaneBeActive = UserSettingsService.InfoPaneSettingsService.IsInfoPaneEnabled && ViewModel.ShouldPreviewPaneBeDisplayed;
442442
ViewModel.ShouldViewControlBeDisplayed = SidebarAdaptiveViewModel.PaneHolder?.ActivePane?.InstanceViewModel?.IsPageTypeNotHome ?? false;
443443

444444
UpdatePositioning();

0 commit comments

Comments
 (0)