Merge pull request #33 from Cy-4AH/app_id

Automatically detect google app id in iOS

Author: snatchev

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -18,7 +18,20 @@ def self.run(params)
         params.values # to validate all inputs before looking for the ipa/apk
         cmd = [Shellwords.escape(params[:firebase_cli_path].chomp), FIREBASECMD_ACTION]
         cmd << Shellwords.escape(params[:ipa_path] || params[:apk_path])
-        cmd << "--app #{params[:app]}"
+        if params[:app]
+          cmd << "--app #{params[:app]}"
+        else
+          platform = Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]
+          case platform
+          when :android
+          else
+            archivePath = Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE]
+            if archivePath
+              cmd << "--app"
+              cmd << findout_ios_app_id_from_archive(archivePath)
+            end
+          end
+        end
 
         cmd << groups_flag(params)
         cmd << testers_flag(params)
@@ -84,7 +97,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :app,
                                        env_name: "FIREBASEAPPDISTRO_APP",
                                        description: "Your app's Firebase App ID. You can find the App ID in the Firebase console, on the General Settings page",
-                                       optional: false,
+                                       optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :firebase_cli_path,
                                        env_name: "FIREBASEAPPDISTRO_FIREBASE_CLI_PATH",

lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb

@@ -1,4 +1,5 @@
 require 'fastlane_core/ui/ui'
+require 'cfpropertylist'
 
 module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?("UI")
@@ -56,6 +57,17 @@ def cleanup_tempfiles
         return if @tempfiles.nil?
         @tempfiles.each(&:unlink)
       end
+
+      def parse_plist(path)
+        CFPropertyList.native_types(CFPropertyList::List.new(:file => path).value)
+      end
+      def findout_ios_app_id_from_archive(path)
+        appPath = parse_plist("#{path}/Info.plist")["ApplicationProperties"]["ApplicationPath"]
+        UI.shell_error! "can't extract application path from Info.plist at #{path}" if appPath.empty?
+        identifier = parse_plist("#{path}/Products/#{appPath}/GoogleService-Info.plist")["GOOGLE_APP_ID"]
+        UI.shell_error! "can't extract GOOGLE_APP_ID" if identifier.empty?
+        return identifier
+      end
     end
   end
 end