Skip to content

Commit cd5c493

Browse files
authored
Switch to node 18, node 16 no longer works with Firebase CLI. (#1499)
1 parent 42b57ec commit cd5c493

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/desktop.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,10 @@ jobs:
343343
if [[ "${{ job.status }}" != "success" ]]; then
344344
exit 1
345345
fi
346-
- name: Set up Node (16)
346+
- name: Set up Node (18)
347347
uses: actions/setup-node@v3
348348
with:
349-
node-version: 16.x
349+
node-version: 18.x
350350
- name: Setup Firestore Emulator
351351
uses: nick-invision/retry@v2
352352
with:

.github/workflows/integration_tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -762,10 +762,10 @@ jobs:
762762
timeout_minutes: 15
763763
max_attempts: 3
764764
command: scripts/gha/install_test_workflow_prereqs.sh -p Desktop -t true -a '${{ matrix.arch }}' -s '${{ matrix.ssl_variant }}'
765-
- name: Set up Node (16)
765+
- name: Set up Node (18)
766766
uses: actions/setup-node@v3
767767
with:
768-
node-version: 16.x
768+
node-version: 18.x
769769
- name: Setup Firestore Emulator
770770
uses: nick-invision/retry@v2
771771
with:
@@ -1155,10 +1155,10 @@ jobs:
11551155
run: |
11561156
echo "device_type=$( python scripts/gha/print_matrix_configuration.py -k ${{ matrix.ios_device }} -get_device_type)" >> $GITHUB_OUTPUT
11571157
echo "device=$( python scripts/gha/print_matrix_configuration.py -k ${{ matrix.ios_device }} -get_ftl_device_list)" >> $GITHUB_OUTPUT
1158-
- name: Set up Node (16)
1158+
- name: Set up Node (18)
11591159
uses: actions/setup-node@v3
11601160
with:
1161-
node-version: 16.x
1161+
node-version: 18.x
11621162
- name: Setup java for Firestore emulator
11631163
uses: actions/setup-java@v3
11641164
with:

0 commit comments

Comments
 (0)