fix: apply requested changes

sneak in change title hover for delete node attributes

Author: Diede Kerkhof

frank-flow/src/frontend/src/app/flow/options/options.component.html

@@ -92,12 +92,10 @@ <h2>Attributes</h2>
             (ngModelChange)="changeAttribute(attribute.key, $event)"
             [ngModel]="attributes[attribute.key].value"
             type="text"
+            title="Delete attribute"
           />
           <app-button (click)="deleteAttribute(attribute.key)">
-            <fa-icon
-              [icon]="['fas', 'trash']"
-              title="Delete attribute"
-            ></fa-icon>
+            <fa-icon [icon]="['fas', 'trash']"></fa-icon>
           </app-button>
         </div>
         <ng-template #inputOnly>

frank-flow/src/frontend/src/app/header/configuration-settings/configuration-settings.component.html

@@ -19,7 +19,7 @@ <h1>Flow settings</h1>
     <div *ngIf="flowSettings">
       <div class="input-row">
         <label
-          for="edit-mode"
+          for="grid-configuration"
           title="Automatically snap a node to a defined grid for easy layout"
           >Snap to grid</label
         >
@@ -49,17 +49,15 @@ <h1>Flow settings</h1>
           <app-button
             *ngIf="flowSettings.gridSize !== undefined"
             (click)="deleteConfigurationSetting('gridSize')"
+            title="Delete setting from configuration"
           >
-            <fa-icon
-              [icon]="['fas', 'trash']"
-              title="Delete attribute"
-            ></fa-icon>
+            <fa-icon [icon]="['fas', 'trash']"></fa-icon>
           </app-button>
         </div>
       </div>
       <div class="input-row">
         <label
-          for="edit-mode"
+          for="grid-configuration"
           title="The style of the connections between nodes"
           >Forward style</label
         >
@@ -96,17 +94,15 @@ <h1>Flow settings</h1>
           <app-button
             *ngIf="flowSettings.forwardStyle"
             (click)="deleteConfigurationSetting('forwardStyle')"
+            title="Delete setting from configuration"
           >
-            <fa-icon
-              [icon]="['fas', 'trash']"
-              title="Delete attribute"
-            ></fa-icon>
+            <fa-icon [icon]="['fas', 'trash']"></fa-icon>
           </app-button>
         </div>
       </div>
       <div class="input-row">
         <label
-          for="edit-mode"
+          for="grid-configuration"
           title="The direction will change the location of the anchor-points on the nodes"
           >Flow direction</label
         >
@@ -137,17 +133,17 @@ <h1>Flow settings</h1>
           <app-button
             *ngIf="flowSettings.direction"
             (click)="deleteConfigurationSetting('direction')"
+            title="Delete setting from configuration"
           >
-            <fa-icon
-              [icon]="['fas', 'trash']"
-              title="Delete attribute"
-            ></fa-icon>
+            <fa-icon [icon]="['fas', 'trash']"></fa-icon>
           </app-button>
         </div>
       </div>
     </div>
     <div *ngIf="!flowSettings">
-      Please wait with editing until the configuration is loaded
+      No configuration element has been found. Please make shure the
+      configuration file includes either &lt;Configuration&gt; or
+      &lt;Module&gt;.
     </div>
   </div>
 </ngx-smart-modal>

frank-flow/src/frontend/src/app/header/header.component.html

@@ -29,7 +29,7 @@
       *ngIf="currentFile?.type === fileType.CONFIGURATION"
       (click)="openConfigurationSettings()"
       color="dark"
-      title="Modify configuration settings"
+      title="Modify flow settings"
     >
       <fa-icon icon="cogs"></fa-icon>
     </app-button>

frank-flow/src/frontend/src/app/shared/services/flow-structure.service.ts

@@ -403,8 +403,11 @@ export class FlowStructureService {
   }
 
   deleteFlowSetting(deleteFlowSetting: string) {
-    const configurationAttributes =
-      this.flowStructure.configuration!.attributes;
+    if (this.flowStructure.configuration == undefined) {
+      return;
+    }
+    const configurationAttributes = this.flowStructure.configuration.attributes;
+
     this.deleteAttribute(deleteFlowSetting, configurationAttributes, true);
   }
 
@@ -478,8 +481,7 @@ export class FlowStructureService {
     | monaco.editor.IIdentifiedSingleEditOperation[]
     | void {
     for (const [nodeId, editAttributes] of this.editAttributeQueue.entries()) {
-      let node: FlowStructureNode | undefined;
-      node = this.currentFile.flowStructure?.nodes.find(
+      const node = this.currentFile.flowStructure?.nodes.find(
         (node: FlowStructureNode) => node.uid === nodeId
       );
       const editOperations: monaco.editor.IIdentifiedSingleEditOperation[] = [];