tests: reproduce update propagation issues with peer blocking tests (#1592)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Ian Clarke <github@ian.33mail.com>
Co-authored-by: Ignacio Duart <iduartgomez@gmail.com>

Author: 3 people

Cargo.lock

@@ -19,6 +19,7 @@ tokio = { version = "1.0", features = ["full"] }
 tokio-tungstenite = "0.26.1"
 tracing = { version = "0.1", features = ["log"] }
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
+humantime = "2.2.0"
 
 [dev-dependencies]
 freenet = { path = "../../../crates/core" }

apps/freenet-ping/Cargo.lock

@@ -33,9 +33,11 @@ impl PingStats {
         self.sent_count += 1;
     }
 
-    pub fn record_received(&mut self, peer: String, time: DateTime<Utc>) {
+    pub fn record_received(&mut self, peer: String, time: Vec<DateTime<Utc>>) {
         *self.received_counts.entry(peer.clone()).or_insert(0) += 1;
-        self.last_updates.insert(peer, time);
+        if let Some(latest) = time.first() {
+            self.last_updates.insert(peer, *latest);
+        }
     }
 }
 
@@ -54,6 +56,21 @@ pub async fn wait_for_put_response(
                     return Err("unexpected key".into());
                 }
             }
+            Ok(Ok(HostResponse::ContractResponse(ContractResponse::UpdateResponse {
+                key,
+                summary,
+            }))) => {
+                if &key == expected_key {
+                    tracing::info!(
+                        "Received update response for key: {}, summary: {:?}",
+                        key,
+                        summary
+                    );
+                    return Ok(key);
+                } else {
+                    return Err("unexpected key".into());
+                }
+            }
             Ok(Ok(other)) => {
                 tracing::warn!("Unexpected response while waiting for put: {}", other);
             }
@@ -85,9 +102,17 @@ pub async fn wait_for_get_response(
                     return Err("unexpected key".into());
                 }
 
-                let old_ping = serde_json::from_slice::<Ping>(&state)?;
-                tracing::info!(num_entries = %old_ping.len(), "old state fetched successfully!");
-                return Ok(old_ping);
+                match serde_json::from_slice::<Ping>(&state) {
+                    Ok(ping) => {
+                        tracing::info!(num_entries = %ping.len(), "old state fetched successfully!");
+                        return Ok(ping);
+                    }
+                    Err(e) => {
+                        tracing::error!("Failed to deserialize Ping: {}", e);
+                        tracing::error!("Raw state data: {:?}", String::from_utf8_lossy(&state));
+                        return Err(Box::new(e));
+                    }
+                };
             }
             Ok(Ok(other)) => {
                 tracing::warn!("Unexpected response while waiting for get: {}", other);
@@ -218,9 +243,13 @@ pub async fn run_ping_client(
 
                                         let updates = local_state.merge(new_ping, parameters.ttl);
 
-                                        for (name, update_time) in updates.into_iter() {
-                                            tracing::info!("{} last updated at {}", name, update_time);
-                                            stats.record_received(name, update_time);
+                                        for (name, timestamps) in updates.into_iter() {
+                                            if !timestamps.is_empty() {
+                                                if let Some(last) = timestamps.first() {
+                                                    tracing::info!("{} last updated at {}", name, last);
+                                                }
+                                                stats.record_received(name, timestamps);
+                                            }
                                         }
                                         Ok(())
                                     };

apps/freenet-ping/app/Cargo.toml

@@ -0,0 +1,97 @@
+# Freenet Ping App Test Suite
+
+This directory contains integration tests for the Freenet Ping application, focusing on contract state propagation in various network topologies and connectivity scenarios.
+
+## Test Organization
+
+| Test File                                | Scenario                                                                                                                    |
+| ---------------------------------------- | --------------------------------------------------------------------------------------------------------------------------- |
+| `run_app.rs`                             | **Multi-node and client functionality tests.** Contains tests for basic multi-node functionality and client application.    |
+| `run_app_blocked_peers.rs`               | **Parameterized blocked peers tests.** A unified implementation of blocked peers tests with different functional behaviors. |
+| `run_app_partially_connected_network.rs` | **Partial connectivity test.** Large-scale network test with controlled connectivity between nodes.                         |
+
+## Parameterized "Blocked Peers" Tests
+
+The `run_app_blocked_peers.rs` file contains a parameterized implementation that consolidates blocked peers testing into a single file. The file provides the following test variants:
+
+| Test Function                      | Description                                                                      |
+| ---------------------------------- | -------------------------------------------------------------------------------- |
+| `test_ping_blocked_peers`          | **Baseline implementation.** Standard test for indirect propagation via gateway. |
+| `test_ping_blocked_peers_simple`   | **Minimal variant.** One round of updates, simplified verification.              |
+| `test_ping_blocked_peers_solution` | **Reference implementation.** Best practices for indirect propagation.           |
+
+## Test Structure
+
+### In `run_app.rs`
+
+| Test Function                | Description                                                    |
+| ---------------------------- | -------------------------------------------------------------- |
+| `test_ping_multi_node`       | Tests basic contract propagation in a fully-connected network. |
+| `test_ping_application_loop` | Tests the complete client application running over time.       |
+
+### In `run_app_partially_connected_network.rs`
+
+| Test Function                           | Description                                                      |
+| --------------------------------------- | ---------------------------------------------------------------- |
+| `test_ping_partially_connected_network` | Tests propagation in a larger network with partial connectivity. |
+
+### Multi-node vs. Partially Connected Tests
+
+- **Multi-node test**: Uses a fully connected network where all nodes can directly communicate with each other
+- **Partially connected test**: Creates a larger network with controlled connectivity ratio (50%) between nodes, testing how updates propagate in a more realistic, constrained network topology
+
+## The "Blocked Peers" Test Scenario
+
+The "blocked peers" tests verify that contract state updates can propagate correctly even when direct peer-to-peer connections are blocked:
+
+1. Two regular nodes (Node1 and Node2) are configured to block each other's network addresses
+2. A gateway node is connected to both regular nodes
+3. All nodes subscribe to the ping contract
+4. Each node sends state updates with its own unique identifier
+5. Updates must route through the gateway to reach nodes with blocked direct connections
+6. The test verifies that all nodes eventually have the same consistent state
+
+This tests Freenet's ability to maintain contract state consistency even when the network topology prevents direct communication between some peers.
+
+## Common Test Infrastructure
+
+The `common/mod.rs` module provides shared infrastructure for tests, including:
+
+- Node and gateway configuration
+- Contract deployment helpers
+- State comparison utilities
+- WebSocket connection management
+- State update and verification functions
+
+## Parameterized Testing Approach
+
+The unified approach in `run_app_blocked_peers.rs` offers several advantages:
+
+- **Reduced duplication**: Core test logic is defined once and reused
+- **Consistent methodology**: All variants follow the same testing pattern
+- **Functional variants**: Tests focus on different functional behaviors (baseline, simple, solution)
+- **Easier maintenance**: Changes to the core test logic only need to be made in one place
+- **Focused test coverage**: Each variant tests a specific functional aspect of the system
+
+## Running the Tests
+
+Run all tests with:
+
+```bash
+cd apps/freenet-ping
+cargo test
+```
+
+Run a specific blocked peers test variant:
+
+```bash
+cargo test test_ping_blocked_peers_simple
+```
+
+Run the large-scale partial connectivity network test:
+
+```bash
+cargo test -p freenet-ping-app --test run_app_partially_connected_network
+```
+
+---