Skip to content

Commit 2e37aee

Browse files
committed
remove duplicate code
1 parent 4825473 commit 2e37aee

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

utils.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -131,16 +131,12 @@ func openFile(filename string) error {
131131
if runtime.GOOS == "windows" {
132132
// On Windows, use "code.cmd"
133133
cmd = exec.Command("code.cmd", filename)
134-
cmd.Stdin = os.Stdin
135-
cmd.Stdout = os.Stdout
136-
cmd.Stderr = os.Stderr
134+
handleCmdOs(cmd)
137135
err := cmd.Run()
138136

139137
if err != nil {
140138
cmd = exec.Command("notepad", filename)
141-
cmd.Stdin = os.Stdin
142-
cmd.Stdout = os.Stdout
143-
cmd.Stderr = os.Stderr
139+
handleCmdOs(cmd)
144140
runErr := cmd.Run()
145141

146142
if runErr != nil {
@@ -151,9 +147,7 @@ func openFile(filename string) error {
151147
} else {
152148
// implement such that the default editor is opened
153149
cmd = exec.Command("editor", filename)
154-
cmd.Stdin = os.Stdin
155-
cmd.Stdout = os.Stdout
156-
cmd.Stderr = os.Stderr
150+
handleCmdOs(cmd)
157151
runErr := cmd.Run()
158152

159153
if runErr != nil {
@@ -168,3 +162,9 @@ func openFile(filename string) error {
168162

169163
return nil
170164
}
165+
166+
func handleCmdOs(cmd *exec.Cmd) {
167+
cmd.Stdin = os.Stdin
168+
cmd.Stdout = os.Stdout
169+
cmd.Stderr = os.Stderr
170+
}

0 commit comments

Comments
 (0)