Skip to content

Commit c8b0780

Browse files
goffrieConvex, Inc.
authored and
Convex, Inc.
committed
Use in_span() on inner_bump_max_repeatable_ts span (#36971)
GitOrigin-RevId: b1d618dcd4b388e74c6f95cd3e00c203dedc2a6d
1 parent d340923 commit c8b0780

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

crates/database/src/committer.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,6 @@ impl<RT: Runtime> Committer<RT> {
257257
span_commit_id = Some(commit_id);
258258
Span::root("bump_max_repeatable", SpanContext::random())
259259
});
260-
let local_span = Span::enter_with_parent("queue_bump_max_repeatable", committer_span);
261-
local_span.set_local_parent();
262260
// Advance the repeatable read timestamp so non-leaders can
263261
// establish a recent repeatable snapshot.
264262
next_bump_wait = None;
@@ -592,7 +590,7 @@ impl<RT: Runtime> Committer<RT> {
592590
let outer_span = Span::enter_with_parent("outer_bump_max_repeatable_ts", root_span);
593591
self.persistence_writes.push_back(
594592
async move {
595-
let _span = Span::enter_with_parent("inner_bump_max_repeatable_ts", &outer_span);
593+
let span = Span::enter_with_parent("inner_bump_max_repeatable_ts", &outer_span);
596594
// The MaxRepeatableTimestamp persistence global ensures all future
597595
// commits on future leaders will be after new_max_repeatable, and followers
598596
// can know this timestamp is repeatable.
@@ -601,6 +599,7 @@ impl<RT: Runtime> Committer<RT> {
601599
PersistenceGlobalKey::MaxRepeatableTimestamp,
602600
new_max_repeatable.into(),
603601
)
602+
.in_span(span)
604603
.await?;
605604
Ok(PersistenceWrite::MaxRepeatableTimestamp {
606605
new_max_repeatable,

0 commit comments

Comments
 (0)