Replies: 1 comment
-
I don't think you'd want the CI to mess with the source code, but it may be a good idea to add an additional check to CI that prevents merging messy formatting. This could be achieved in a non-obtrusive manner by using lint-diffs, which only checks modified lines. I was actually trying to get this to work on llama.cpp but with cpplint, but it turns out that one is actually quite opinionated (in a not so good way IMO). clang-tidy may be a better choice. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
We could use the clang-format to generate a .clang-format file with formatting configurations and apply it on the CI, that will keep all the C/C++ code of the project with a consistent looking.
Cang format has some predefined settings that can be customized.
https://clang.llvm.org/docs/ClangFormat.html
And the .clang-format file is normally used by the clangd LSP to run the format command.
Beta Was this translation helpful? Give feedback.
All reactions