Review/Rationalise the environment and configuration options used by Bitbucket Cloud and DC #769
Description
Description
Currently the implemented support for Bitbucket Cloud and DC includes a duplicated set of configuration or environment options e.g.
credential.bitbucketDataCenterOAuthClientSecret vs credential.cloudOAuthClientSecret
GCM_BITBUCKET_DATACENTER_CLIENTID vs GCM_BITBUCKET_CLOUD_CLIENTID
Conceptually there should be no reason for duplicating the configuration options because the use of the target url in the configuration should be sufficient to differentiate between cloud vs DC.
e.g.
credential.http://bitbucket.org.oauthClientSecret vs credential.http://example.com/bitbucket.oauthClientSecret
However it is not as clear cut with the Environment variables, since they do not have the flexibility to target explicit urls, so they should probably stay distinct cloud vs DC.