Declarations6: add RULE-5-8 and RULE-5-9

Author: knewbury01

c/misra/src/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.ql

@@ -0,0 +1,24 @@
+/**
+ * @id c/misra/identifiers-with-external-linkage-not-unique
+ * @name RULE-5-8: Identifiers that define objects or functions with external linkage shall be unique
+ * @description Using non-unique identifiers can lead to developer confusion.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-5-8
+ *       maintainability
+ *       readability
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.Identifiers
+
+from Declaration de, ExternalIdentifiers e
+where
+  not isExcluded(de, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
+  not isExcluded(e, Declarations6Package::identifiersWithExternalLinkageNotUniqueQuery()) and
+  not de = e and
+  de.getName() = e.getName()
+select de, "Identifier conflicts with external identifier $@", e, e.getName()

c/misra/src/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.ql

@@ -0,0 +1,32 @@
+/**
+ * @id c/misra/identifiers-with-internal-linkage-not-unique
+ * @name RULE-5-9: Identifiers that define objects or functions with internal linkage should be unique
+ * @description Using non-unique identifiers can lead to developer confusion.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-5-9
+ *       maintainability
+ *       readability
+ *       external/misra/obligation/advisory
+ */
+
+import cpp
+import codingstandards.c.misra
+
+from Declaration d1, Declaration d2
+where
+  not isExcluded(d1, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
+  not isExcluded(d2, Declarations6Package::identifiersWithInternalLinkageNotUniqueQuery()) and
+  d1.isStatic() and
+  d1.isTopLevel() and
+  not d1 = d2 and
+  d1.getName() = d2.getName() and
+  // Apply an ordering based on location to enforce that (d1, d2) = (d2, d1) and we only report (d1, d2).
+  (
+    d1.getFile().getAbsolutePath() < d2.getFile().getAbsolutePath()
+    or
+    d1.getFile().getAbsolutePath() = d2.getFile().getAbsolutePath() and
+    d1.getLocation().getStartLine() < d2.getLocation().getStartLine()
+  )
+select d2, "Identifier conflicts with identifier $@ with internal linkage.", d1, d1.getName()

c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.expected

@@ -0,0 +1,2 @@
+| test1.c:1:13:1:13 | f | Identifier conflicts with external identifier $@ | test.c:3:6:3:6 | f | f |
+| test1.c:2:7:2:7 | g | Identifier conflicts with external identifier $@ | test.c:1:5:1:5 | g | g |

c/misra/test/rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.qlref

@@ -0,0 +1 @@
+rules/RULE-5-8/IdentifiersWithExternalLinkageNotUnique.ql

c/misra/test/rules/RULE-5-8/test.c

@@ -0,0 +1,3 @@
+int g;
+extern int g1; // COMPLIANT
+void f() { int i; }

c/misra/test/rules/RULE-5-8/test1.c

@@ -0,0 +1,5 @@
+static void f() { // NON_COMPLIANT
+  int g;          // NON_COMPLIANT
+  int i;          // COMPLIANT
+}
+int g1; //COMPLIANT

c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.expected

@@ -0,0 +1,4 @@
+| test1.c:3:12:3:13 | g1 | Identifier conflicts with identifier $@ with internal linkage. | test.c:2:12:2:13 | g1 | g1 |
+| test1.c:5:13:5:13 | f | Identifier conflicts with identifier $@ with internal linkage. | test.c:3:13:3:13 | f | f |
+| test1.c:6:7:6:7 | g | Identifier conflicts with identifier $@ with internal linkage. | test1.c:2:12:2:12 | g | g |
+| test1.c:11:7:11:7 | g | Identifier conflicts with identifier $@ with internal linkage. | test1.c:2:12:2:12 | g | g |

c/misra/test/rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.qlref

@@ -0,0 +1 @@
+rules/RULE-5-9/IdentifiersWithInternalLinkageNotUnique.ql

c/misra/test/rules/RULE-5-9/test.c

@@ -0,0 +1,2 @@
+static int g1;   // NON_COMPLIANT
+static void f(); // NON_COMPLIANT

c/misra/test/rules/RULE-5-9/test1.c

@@ -0,0 +1,12 @@
+static int g;  // COMPLIANT
+static int g1; // NON_COMPLIANT
+
+static void f() { // NON_COMPLIANT
+  int g;          // NON_COMPLIANT
+  int g2;         // COMPLIANT
+}
+
+void f1() { // COMPLIANT
+  int g;    // NON_COMPLIANT
+  int g2;   // COMPLIANT
+}