Skip to content

Commit b91a2cc

Browse files
committed
Shared: Use 'isSink/1' in 'PropagateFlowConfig'.
1 parent b4c98b4 commit b91a2cc

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,14 @@ module MakeModelGenerator<
484484
}
485485

486486
predicate isSink(DataFlow::Node sink, FlowState state) {
487+
// Sinks are provided by `isSink/1`
488+
none()
489+
}
490+
491+
predicate isSink(DataFlow::Node sink) {
487492
sink instanceof ReturnNodeExt and
488493
not isOwnInstanceAccessNode(sink) and
489-
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink))) and
490-
(state instanceof TaintRead or state instanceof TaintStore)
494+
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink)))
491495
}
492496

493497
predicate isAdditionalFlowStep(

0 commit comments

Comments
 (0)