Skip to content

Commit 3cb6a4a

Browse files
authored
refactor: improve PAT login experience (#1002)
1 parent 171fe1d commit 3cb6a4a

File tree

5 files changed

+23
-21
lines changed

5 files changed

+23
-21
lines changed

src/components/fields/FieldInput.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const FieldInput: FC<IFieldInput> = ({
2121
return (
2222
<Field name={name}>
2323
{({ input, meta: { touched, error } }) => (
24-
<div className="mt-2">
24+
<div className="mb-4">
2525
<label
2626
className="block tracking-wide text-grey-dark text-sm font-semibold mb-2"
2727
htmlFor={input.name}

src/components/fields/__snapshots__/FieldInput.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/routes/LoginWithToken.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,17 @@ export const LoginWithToken: FC = () => {
6767
helpText={
6868
<div>
6969
<div>
70-
Create a Personal Access Token on GitHub and paste above.
71-
</div>
72-
<div>
73-
The required scopes will be selected for you.{' '}
7470
<button
7571
type="button"
76-
className={`px-2 py-1 my-2 text-xs ${buttonClasses}`}
72+
className={`px-2 py-1 text-xs ${buttonClasses}`}
7773
onClick={() => openLink(getNewTokenURL())}
7874
>
7975
Generate a PAT
80-
</button>
76+
</button>{' '}
77+
on GitHub and paste above.
78+
</div>
79+
<div className="italic mt-1">
80+
The required scopes will be selected for you.
8181
</div>
8282
</div>
8383
}
@@ -90,7 +90,7 @@ export const LoginWithToken: FC = () => {
9090
helpText={
9191
<div>
9292
<div>Defaults to github.com.</div>
93-
<div className="italic">
93+
<div className="italic mt-1">
9494
Change only if you are using GitHub Enterprise Server.
9595
</div>
9696
</div>

src/routes/__snapshots__/LoginEnterprise.test.tsx.snap

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/routes/__snapshots__/LoginWithToken.test.tsx.snap

Lines changed: 11 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)