Skip to content

Commit 2d92f1a

Browse files
Add missing fields to ApprovalRule (#1265)
* Add protectedBranches * Add reportType * Add appliesToAllProtectedBranches --------- Co-authored-by: Jeremie Bresson <jeremie.bresson@unblu.com>
1 parent 4f8d54f commit 2d92f1a

File tree

2 files changed

+55
-0
lines changed

2 files changed

+55
-0
lines changed

gitlab4j-models/src/main/java/org/gitlab4j/api/models/ApprovalRule.java

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public class ApprovalRule implements Serializable {
1111
private Long id;
1212
private String name;
1313
private String ruleType;
14+
private String reportType;
1415
private List<User> eligibleApprovers;
1516
private Integer approvalsRequired;
1617
private ApprovalRule sourceRule;
@@ -19,6 +20,8 @@ public class ApprovalRule implements Serializable {
1920
private Boolean containsHiddenGroups;
2021
private List<User> approvedBy;
2122
private Boolean approved;
23+
private Boolean appliesToAllProtectedBranches;
24+
private List<ProtectedBranch> protectedBranches;
2225

2326
public Long getId() {
2427
return id;
@@ -44,6 +47,14 @@ public void setRuleType(String ruleType) {
4447
this.ruleType = ruleType;
4548
}
4649

50+
public String getReportType() {
51+
return reportType;
52+
}
53+
54+
public void setReportType(String reportType) {
55+
this.reportType = reportType;
56+
}
57+
4758
public List<User> getEligibleApprovers() {
4859
return eligibleApprovers;
4960
}
@@ -100,6 +111,14 @@ public void setApprovedBy(List<User> approvedBy) {
100111
this.approvedBy = approvedBy;
101112
}
102113

114+
public Boolean getAppliesToAllProtectedBranches() {
115+
return appliesToAllProtectedBranches;
116+
}
117+
118+
public void setAppliesToAllProtectedBranches(Boolean appliesToAllProtectedBranches) {
119+
this.appliesToAllProtectedBranches = appliesToAllProtectedBranches;
120+
}
121+
103122
public Boolean getApproved() {
104123
return approved;
105124
}
@@ -108,6 +127,14 @@ public void setApproved(Boolean approved) {
108127
this.approved = approved;
109128
}
110129

130+
public List<ProtectedBranch> getProtectedBranches() {
131+
return protectedBranches;
132+
}
133+
134+
public void setProtectedBranches(List<ProtectedBranch> protectedBranches) {
135+
this.protectedBranches = protectedBranches;
136+
}
137+
111138
@Override
112139
public String toString() {
113140
return (JacksonJson.toJsonString(this));

gitlab4j-models/src/test/resources/org/gitlab4j/models/approval-rule.json

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"id": 1,
33
"name": "security",
44
"rule_type": "regular",
5+
"report_type": "code_coverage",
56
"eligible_approvers": [
67
{
78
"id": 2,
@@ -39,11 +40,38 @@
3940
"description": "",
4041
"visibility": "public",
4142
"lfs_enabled": false,
43+
"avatar_url": "https://www.gravatar.com/avatar/0?s=80&d=identicon",
4244
"web_url": "http://localhost/groups/group1",
4345
"request_access_enabled": false,
4446
"full_name": "group1",
4547
"full_path": "group1"
4648
}
4749
],
50+
"applies_to_all_protected_branches": false,
51+
"protected_branches": [
52+
{
53+
"id": 1,
54+
"name": "main",
55+
"push_access_levels": [
56+
{
57+
"access_level": 30,
58+
"access_level_description": "Developers + Maintainers"
59+
}
60+
],
61+
"merge_access_levels": [
62+
{
63+
"access_level": 30,
64+
"access_level_description": "Developers + Maintainers"
65+
}
66+
],
67+
"unprotect_access_levels": [
68+
{
69+
"access_level": 40,
70+
"access_level_description": "Maintainers"
71+
}
72+
],
73+
"code_owner_approval_required": false
74+
}
75+
],
4876
"contains_hidden_groups": false
4977
}

0 commit comments

Comments
 (0)