Get the bar green again

Also tested by flipping line 244 of lib/XML/XPathScript.pm to

  our $XML_parser = 'XML::XPath';

* Add get_qualified_name() in all the XML parser adapters, and provide
  suitable implementations for all three APIs. (For B::XPath it is
  more of a shot in the dark - I don't suppose B opcodes have
  namespaces)

* By default, pretty-print the opening and closing tags of a node in
  terms of their get_qualified_name() instead of their get_name()

Author: Dominique Quatravaux

lib/XML/XPathScript/Processor.pm

@@ -632,7 +632,7 @@ sub translate_comment_node {
 sub start_tag {
     my( $self, $node, $name ) = @_;
 
-    $name ||= $self->get_node_name( $node ) or return;
+    $name ||= $self->get_qualified_name( $node ) or return;
 
     my $string = '<'.$name;
 
@@ -653,7 +653,7 @@ sub start_tag {
 
 sub end_tag {
     my $self = shift;
-    if (my $name = $_[1] || $self->get_node_name( $_[0] ) ) {
+    if (my $name = $_[1] || $self->get_qualified_name( $_[0] ) ) {
         return "</$name>";
     }
 	return '';

lib/XML/XPathScript/Processor/B.pm

@@ -31,6 +31,8 @@ sub to_string {
 
 sub get_node_name { $_[1]->get_name }
 
+sub get_qualified_name { $_[1]->get_name }
+
 sub get_attributes {
     if ( $_[1]->can( 'get_attr_names' ) ) {
         return map { ( [ $_ => $_[1]->get_attr_value( $_ ) ] )

lib/XML/XPathScript/Processor/LibXML.pm

@@ -19,14 +19,15 @@ sub is_text_node {
            && !$_[1]->isa('XML::LibXML::Comment');
 }
 
-sub get_attributes   { return $_[1]->attributes }
-sub get_text_content { return $_[1]->textContent }
-sub get_child_nodes  { return $_[1]->childNodes }
-sub get_node_name    { return $_[1]->localname }
-sub is_element_node  { return $_[1]->isa( 'XML::LibXML::Element' ); }
-sub is_comment_node  { return $_[1]->isa( 'XML::LibXML::Comment' ); }
-sub is_pi_node       { return $_[1]->isa( 'XML::LibXML::PI' ); }
-sub is_nodelist      { return $_[1]->isa( 'XML::LibXML::NodeList' ); }
+sub get_attributes     { return $_[1]->attributes }
+sub get_text_content   { return $_[1]->textContent }
+sub get_child_nodes    { return $_[1]->childNodes }
+sub get_node_name      { return $_[1]->localname }
+sub get_qualified_name { return $_[1]->nodeName }
+sub is_element_node    { return $_[1]->isa( 'XML::LibXML::Element' ); }
+sub is_comment_node    { return $_[1]->isa( 'XML::LibXML::Comment' ); }
+sub is_pi_node         { return $_[1]->isa( 'XML::LibXML::PI' ); }
+sub is_nodelist        { return $_[1]->isa( 'XML::LibXML::NodeList' ); }
 
 sub get_attribute {
     return $_[1]->isa( 'XML::LibXML::Namespace' )

lib/XML/XPathScript/Processor/XPath.pm

@@ -12,15 +12,16 @@ sub get_namespace {
         return $_[1]->getNamespace( $prefix )->getExpanded();
 }
 
-sub get_attributes   { $_[1]->getAttributeNodes }
-sub get_text_content { $_[1]->getData }
-sub get_child_nodes  { $_[1]->getChildNodes }
-sub get_node_name    { $_[1]->getName && $_[1]->getLocalName }
-sub is_element_node  { $_[1]->isa( 'XML::XPath::Node::Element' ); }
-sub is_text_node     { $_[1]->isa( 'XML::XPath::Node::Text' ); }
-sub is_comment_node  { $_[1]->isa( 'XML::XPath::Node::Comment' ); }
-sub is_pi_node       { $_[1]->isa( "XML::XPath::Node::PI" ); }
-sub is_nodelist      { $_[1]->isa( 'XML::XPath::NodeSet' ); }
-sub get_attribute    { $_[1]->toString }
+sub get_attributes     { $_[1]->getAttributeNodes }
+sub get_text_content   { $_[1]->getData }
+sub get_child_nodes    { $_[1]->getChildNodes }
+sub get_node_name      { $_[1]->getName && $_[1]->getLocalName }
+sub get_qualified_name { $_[1]->getName }
+sub is_element_node    { $_[1]->isa( 'XML::XPath::Node::Element' ); }
+sub is_text_node       { $_[1]->isa( 'XML::XPath::Node::Text' ); }
+sub is_comment_node    { $_[1]->isa( 'XML::XPath::Node::Comment' ); }
+sub is_pi_node         { $_[1]->isa( "XML::XPath::Node::PI" ); }
+sub is_nodelist        { $_[1]->isa( 'XML::XPath::NodeSet' ); }
+sub get_attribute      { $_[1]->toString }
 
 1;