Fix filter no project and attach project no work issue

Author: tyroneyeh

models/db/search.go

@@ -37,4 +37,5 @@ const (
 	// Which means a condition to filter the records which don't match any id.
 	// It's different from zero which means the condition could be ignored.
 	NoConditionID = -1
+	NoProjectID   = -1
 )

models/issues/issue_project.go

@@ -123,7 +123,7 @@ func IssueAssignOrRemoveProject(ctx context.Context, issue *Issue, doer *user_mo
 			}{}
 			if _, err := db.GetEngine(ctx).Select("count(*) as issue_count").Table("project_issue").
 				Where("project_id=?", newProjectID).
-				And("project_board_id=?", newColumnID).
+				And("issue_id=?", issue.ID).
 				Get(&res); err != nil {
 				return err
 			}

modules/indexer/issues/db/options.go

@@ -84,6 +84,14 @@ func ToDBOptions(ctx context.Context, options *internal.SearchOptions) (*issue_m
 		opts.MilestoneIDs = options.MilestoneIDs
 	}
 
+	if len(options.ProjectIDs) == 1 {
+		if options.ProjectIDs[0] == 0 {
+			opts.ProjectID = db.NoProjectID
+		} else {
+			opts.ProjectID = options.ProjectIDs[0]
+		}
+	}
+
 	if options.NoLabelOnly {
 		opts.LabelIDs = []int64{0} // Be careful, it's zero, not db.NoConditionID
 	} else {

modules/indexer/issues/dboptions.go

@@ -49,7 +49,12 @@ func ToSearchOptions(keyword string, opts *issues_model.IssuesOptions) *SearchOp
 		return nil
 	}
 
-	searchOpt.ProjectIDs = convertID(opts.ProjectID)
+	if opts.ProjectID == db.NoProjectID {
+		searchOpt.ProjectIDs = []int64{0}
+	} else {
+		searchOpt.ProjectIDs = convertID(opts.ProjectID)
+	}
+
 	searchOpt.ProjectColumnID = convertID(opts.ProjectColumnID)
 	searchOpt.PosterID = convertID(opts.PosterID)
 	searchOpt.AssigneeID = convertID(opts.AssigneeID)