Merge pull request #199 from ajpetersons/master

LyricTian · web-flow · commit ea58e54a38bc · 2021-12-06T09:04:42.000+08:00
Handle invalid code challenge methods
diff --git a/server/server.go b/server/server.go
@@ -182,7 +182,7 @@ func (s *Server) ValidationAuthorizeRequest(r *http.Request) (*AuthorizeRequest,
 	if ccm == "" {
 		ccm = oauth2.CodeChallengePlain
 	}
-	if ccm.String() != "" && !s.CheckCodeChallengeMethod(ccm) {
+	if ccm != "" && !s.CheckCodeChallengeMethod(ccm) {
 		return nil, errors.ErrUnsupportedCodeChallengeMethod
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ func (s Server) ValidationAuthorizeRequest(r http.Request) (*AuthorizeRequest,`
`182`	`182`	`if ccm == "" {`
`183`	`183`	`ccm = oauth2.CodeChallengePlain`
`184`	`184`	`}`
`185`		`- if ccm.String() != "" && !s.CheckCodeChallengeMethod(ccm) {`
	`185`	`+ if ccm != "" && !s.CheckCodeChallengeMethod(ccm) {`
`186`	`186`	`return nil, errors.ErrUnsupportedCodeChallengeMethod`
`187`	`187`	`}`
`188`	`188`