build(deps): bump github.com/uudashr/iface from 1.3.2 to 1.4.0 (#5820)

dependabot[bot] · ldez · web-flow · commit 36ddc0e035ac · 2025-05-20T20:25:19.000+02:00
Co-authored-by: Fernandez Ludovic &lt;ldez@users.noreply.github.com&gt;
diff --git a/.golangci.next.reference.yml b/.golangci.next.reference.yml
@@ -1795,6 +1795,7 @@ linters:
         - identical # Identifies interfaces in the same package that have identical method sets.
         - unused # Identifies interfaces that are not used anywhere in the same package where the interface is defined.
         - opaque # Identifies functions that return interfaces, but the actual returned value is always a single concrete implementation.
+        - unexported # Identifies interfaces that are not exported but are used in exported functions or methods.
       settings:
         unused:
           # List of packages path to exclude from the check.
diff --git a/go.mod b/go.mod
@@ -119,7 +119,7 @@ require (
 	github.com/ultraware/funlen v0.2.0
 	github.com/ultraware/whitespace v0.2.0
 	github.com/uudashr/gocognit v1.2.0
-	github.com/uudashr/iface v1.3.2
+	github.com/uudashr/iface v1.4.0
 	github.com/valyala/quicktemplate v1.8.0
 	github.com/xen0n/gosmopolitan v1.3.0
 	github.com/yagipy/maintidx v1.0.0
diff --git a/go.sum b/go.sum
diff --git a/jsonschema/golangci.next.jsonschema.json b/jsonschema/golangci.next.jsonschema.json
@@ -661,7 +661,8 @@
       "enum": [
         "identical",
         "unused",
-        "opaque"
+        "opaque",
+        "unexported"
       ]
     },
     "tagliatelle-cases": {
diff --git a/pkg/golinters/iface/iface.go b/pkg/golinters/iface/iface.go
@@ -5,6 +5,7 @@ import (
 
 	"github.com/uudashr/iface/identical"
 	"github.com/uudashr/iface/opaque"
+	"github.com/uudashr/iface/unexported"
 	"github.com/uudashr/iface/unused"
 	"golang.org/x/tools/go/analysis"
 
@@ -28,9 +29,10 @@ func New(settings *config.IfaceSettings) *goanalysis.Linter {
 
 func analyzersFromSettings(settings *config.IfaceSettings) []*analysis.Analyzer {
 	allAnalyzers := map[string]*analysis.Analyzer{
-		"identical": identical.Analyzer,
-		"unused":    unused.Analyzer,
-		"opaque":    opaque.Analyzer,
+		"identical":  identical.Analyzer,
+		"unused":     unused.Analyzer,
+		"opaque":     opaque.Analyzer,
+		"unexported": unexported.Analyzer,
 	}
 
 	if settings == nil || len(settings.Enable) == 0 {
diff --git a/pkg/golinters/iface/testdata/iface_all.go b/pkg/golinters/iface/testdata/iface_all.go
@@ -6,11 +6,11 @@ import "fmt"
 
 // identical
 
-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
@@ -28,7 +28,7 @@ func (s server) Serve() error {
 	return nil
 }
 
-func NewServer(addr string) Server { // want "opaque: NewServer function return Server interface at the 1st result, abstract a single concrete implementation of \\*server"
+func NewServer(addr string) Server { // want "opaque: 'NewServer' function return 'Server' interface at the 1st result, abstract a single concrete implementation of '\\*server'"
 	return &server{addr: addr}
 }
 
@@ -39,7 +39,7 @@ type User struct {
 	Name string
 }
 
-type UserRepository interface { // want "unused: interface UserRepository is declared but not used within the package"
+type UserRepository interface { // want "unused: interface 'UserRepository' is declared but not used within the package"
 	UserOf(id string) (*User, error)
 }
 
diff --git a/pkg/golinters/iface/testdata/iface_cgo.go b/pkg/golinters/iface/testdata/iface_cgo.go
@@ -24,11 +24,11 @@ func _() {
 
 // identical
 
-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
diff --git a/pkg/golinters/iface/testdata/iface_default.go b/pkg/golinters/iface/testdata/iface_default.go
@@ -5,11 +5,11 @@ import "fmt"
 
 // identical
 
-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
diff --git a/pkg/golinters/iface/testdata/iface_identical.go b/pkg/golinters/iface/testdata/iface_identical.go
@@ -6,11 +6,11 @@ import "fmt"
 
 // identical
 
-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"
 	Ping() error
 }
 
diff --git a/pkg/golinters/iface/testdata/iface_opaque.go b/pkg/golinters/iface/testdata/iface_opaque.go
@@ -28,7 +28,7 @@ func (s server) Serve() error {
 	return nil
 }
 
-func NewServer(addr string) Server { // want "opaque: NewServer function return Server interface at the 1st result, abstract a single concrete implementation of \\*server"
+func NewServer(addr string) Server { // want "opaque: 'NewServer' function return 'Server' interface at the 1st result, abstract a single concrete implementation of '\\*server'"
 	return &server{addr: addr}
 }
 
diff --git a/pkg/golinters/iface/testdata/iface_unexported.go b/pkg/golinters/iface/testdata/iface_unexported.go
@@ -0,0 +1,84 @@
+//golangcitest:args -Eiface
+//golangcitest:config_path testdata/iface_unexported.yml
+package testdata
+
+import "fmt"
+
+// identical
+
+type Pinger interface {
+	Ping() error
+}
+
+type Healthcheck interface {
+	Ping() error
+}
+
+// opaque
+
+type Server interface {
+	Serve() error
+}
+
+type server struct {
+	addr string
+}
+
+func (s server) Serve() error {
+	return nil
+}
+
+func NewServer(addr string) Server {
+	return &server{addr: addr}
+}
+
+// unused
+
+type User struct {
+	ID   string
+	Name string
+}
+
+type UserRepository interface {
+	UserOf(id string) (*User, error)
+}
+
+type UserRepositorySQL struct {
+}
+
+func (r *UserRepositorySQL) UserOf(id string) (*User, error) {
+	return nil, nil
+}
+
+type Granter interface {
+	Grant(permission string) error
+}
+
+func AllowAll(g Granter) error {
+	return g.Grant("all")
+}
+
+type Allower interface {
+	Allow(permission string) error
+}
+
+func Allow(x any) {
+	_ = x.(Allower)
+	fmt.Println("allow")
+}
+
+// unexported
+
+type unexportedReader interface {
+	Read([]byte) (int, error)
+}
+
+func ReadAll(r unexportedReader) ([]byte, error) { // want "unexported interface 'unexportedReader' used as parameter in exported function 'ReadAll'"
+	buf := make([]byte, 1024)
+	_, err := r.Read(buf)
+	return buf, err
+}
+
+func NewUnexportedReader() unexportedReader { // want "unexported interface 'unexportedReader' used as return value in exported function 'NewUnexportedReader'"
+	return nil // stub
+}
diff --git a/pkg/golinters/iface/testdata/iface_unexported.yml b/pkg/golinters/iface/testdata/iface_unexported.yml
@@ -0,0 +1,7 @@
+version: "2"
+
+linters:
+  settings:
+    iface:
+      enable:
+        - unexported
diff --git a/pkg/golinters/iface/testdata/iface_unused.go b/pkg/golinters/iface/testdata/iface_unused.go
@@ -6,11 +6,11 @@ import "fmt"
 
 // identical
 
-type Pinger interface { // want "unused: interface Pinger is declared but not used within the package"
+type Pinger interface { // want "unused: interface 'Pinger' is declared but not used within the package"
 	Ping() error
 }
 
-type Healthcheck interface { // want "unused: interface Healthcheck is declared but not used within the package"
+type Healthcheck interface { // want "unused: interface 'Healthcheck' is declared but not used within the package"
 	Ping() error
 }
 
@@ -39,7 +39,7 @@ type User struct {
 	Name string
 }
 
-type UserRepository interface { // want "unused: interface UserRepository is declared but not used within the package"
+type UserRepository interface { // want "unused: interface 'UserRepository' is declared but not used within the package"
 	UserOf(id string) (*User, error)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,11 @@ import "fmt"`
`6`	`6`
`7`	`7`	`// identical`
`8`	`8`
`9`		`-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"`
	`9`	`+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"`
`10`	`10`	`Ping() error`
`11`	`11`	`}`
`12`	`12`
`13`		`-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"`
	`13`	`+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"`
`14`	`14`	`Ping() error`
`15`	`15`	`}`
`16`	`16`
`@@ -28,7 +28,7 @@ func (s server) Serve() error {`
`28`	`28`	`return nil`
`29`	`29`	`}`
`30`	`30`
`31`		`-func NewServer(addr string) Server { // want "opaque: NewServer function return Server interface at the 1st result, abstract a single concrete implementation of \\*server"`
	`31`	`+func NewServer(addr string) Server { // want "opaque: 'NewServer' function return 'Server' interface at the 1st result, abstract a single concrete implementation of '\\*server'"`
`32`	`32`	`return &server{addr: addr}`
`33`	`33`	`}`
`34`	`34`
`@@ -39,7 +39,7 @@ type User struct {`
`39`	`39`	`Name string`
`40`	`40`	`}`
`41`	`41`
`42`		`-type UserRepository interface { // want "unused: interface UserRepository is declared but not used within the package"`
	`42`	`+type UserRepository interface { // want "unused: interface 'UserRepository' is declared but not used within the package"`
`43`	`43`	`UserOf(id string) (*User, error)`
`44`	`44`	`}`
`45`	`45`
Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,11 @@ func _() {`
`24`	`24`
`25`	`25`	`// identical`
`26`	`26`
`27`		`-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"`
	`27`	`+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"`
`28`	`28`	`Ping() error`
`29`	`29`	`}`
`30`	`30`
`31`		`-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"`
	`31`	`+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"`
`32`	`32`	`Ping() error`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,11 @@ import "fmt"`
`5`	`5`
`6`	`6`	`// identical`
`7`	`7`
`8`		`-type Pinger interface { // want "identical: interface Pinger contains identical methods or type constraints from another interface, causing redundancy"`
	`8`	`+type Pinger interface { // want "identical: interface 'Pinger' contains identical methods or type constraints with another interface, causing redundancy"`
`9`	`9`	`Ping() error`
`10`	`10`	`}`
`11`	`11`
`12`		`-type Healthcheck interface { // want "identical: interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"`
	`12`	`+type Healthcheck interface { // want "identical: interface 'Healthcheck' contains identical methods or type constraints with another interface, causing redundancy"`
`13`	`13`	`Ping() error`
`14`	`14`	`}`
`15`	`15`