From e995f75d9179159429e638e2f57b49a9bfa649e0 Mon Sep 17 00:00:00 2001 From: "FGH\\Koen" Date: Tue, 13 Feb 2018 11:53:46 +0100 Subject: [PATCH 1/2] Fix Issue #12 Android google signin crash when add AdditionalScopes in configuration bug --- native-googlesignin/src/main/cpp/google_signin.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/native-googlesignin/src/main/cpp/google_signin.cc b/native-googlesignin/src/main/cpp/google_signin.cc index b23441d2..be269349 100644 --- a/native-googlesignin/src/main/cpp/google_signin.cc +++ b/native-googlesignin/src/main/cpp/google_signin.cc @@ -234,7 +234,7 @@ void GoogleSignIn::GoogleSignInImpl::Configure( delete current_result_; current_result_ = new GoogleSignInFuture(); - CallConfigure(); + //CallConfigure(); } void GoogleSignIn::GoogleSignInImpl::CallConfigure() { From 7e035c55f4907078db173773978955d8845d9c53 Mon Sep 17 00:00:00 2001 From: "FGH\\Koen" Date: Tue, 13 Feb 2018 17:27:36 +0100 Subject: [PATCH 2/2] Apparently it was the other way arround. --- native-googlesignin/src/main/cpp/google_signin.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/native-googlesignin/src/main/cpp/google_signin.cc b/native-googlesignin/src/main/cpp/google_signin.cc index be269349..964463d0 100644 --- a/native-googlesignin/src/main/cpp/google_signin.cc +++ b/native-googlesignin/src/main/cpp/google_signin.cc @@ -234,7 +234,7 @@ void GoogleSignIn::GoogleSignInImpl::Configure( delete current_result_; current_result_ = new GoogleSignInFuture(); - //CallConfigure(); + CallConfigure(); } void GoogleSignIn::GoogleSignInImpl::CallConfigure() { @@ -299,7 +299,7 @@ Future &GoogleSignIn::GoogleSignInImpl::SignIn() { current_result_->SetResult(nullptr); } - CallConfigure(); + //CallConfigure(); env->CallStaticVoidMethod(helper_clazz_, signin_method_, activity_, (jlong)current_result_); @@ -315,7 +315,7 @@ Future current_result_->SetResult(nullptr); } - CallConfigure(); + //CallConfigure(); env->CallStaticVoidMethod(helper_clazz_, signinsilently_method_, activity_, (jlong)current_result_);