It seems like there is still an issue, the apollo-server error functions do not like something about the gateway config setup.

Here is my code:

const server = new ApolloServer({
      // See this issue for more info on this solution: https://github.com/Urigo/graphql-modules/issues/2270
      // schema: application.createSchemaForApollo() // graphql-modules has marked this deprecated, but works with Apollo Server 4.
      // Recommended approach is to use gateway:
      gateway: {
        async load() {
          return { executor: moduleApp.createApolloExecutor() }
        },
        onSchemaLoadOrUpdate(callback) {
          const apiSchema = { apiSchema: moduleApp.schema } as any
          callback(apiSchema)
          return () => {}
        },
        async stop() {}
      },
      formatError: (formattedError: GraphQLFormattedError, error: any) => {
        console.log('FORMATTED ERROR -----> ', formattedError)
        console.log('ERROR -----> ', error)
        return formattedError
      }      
})

await server.start()

app.use(`${basePath}/graphql`, expressMiddleware(server))

It never seems to make it to the formatError function before blowing up when an error occurs. With the above setup you can simply query for a field that does not exist to generate the below errors...

I receive the following errors:

Unexpected error processing request: TypeError: Cannot assign to read only property 'name' of object 'GraphQLError

Followed by:

TypeError: Cannot read property 'code' of undefined
    at enrichError (/node_modules/@apollo/server/dist/cjs/errorNormalize.js:34:43)
    at /node_modules/@apollo/server/dist/cjs/errorNormalize.js:19:28
    at Array.map (<anonymous>)
    at normalizeAndFormatErrors (/node_modules/@apollo/server/dist/cjs/errorNormalize.js:13:33)
    at ApolloServer.errorResponse (/node_modules/@apollo/server/dist/cjs/ApolloServer.js:542:102)
    at ApolloServer.executeHTTPGraphQLRequest (node_modules/@apollo/server/dist/cjs/ApolloServer.js:538:25)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
^[[1;2C

any ideas?

Apollo 4 support #2270

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions