Added comments for if False checks

syrusakbary · syrusakbary · commit 2f6ddd7c7e68 · 2018-07-02T09:52:28.000-07:00
diff --git a/graphql/backend/__init__.py b/graphql/backend/__init__.py
@@ -9,6 +9,7 @@
 from .decider import GraphQLDeciderBackend
 from .cache import GraphQLCachedBackend
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Union
 
diff --git a/graphql/backend/base.py b/graphql/backend/base.py
@@ -4,6 +4,7 @@
 from abc import ABCMeta, abstractmethod
 import six
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Dict, Optional, Union, Callable
     from ..language.ast import Document
diff --git a/graphql/backend/cache.py b/graphql/backend/cache.py
@@ -4,6 +4,7 @@
 
 from .base import GraphQLBackend
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Dict, Optional, Union, Tuple, Hashable
     from .base import GraphQLDocument
diff --git a/graphql/backend/compiled.py b/graphql/backend/compiled.py
@@ -1,6 +1,7 @@
 from six import string_types
 from .base import GraphQLDocument
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.schema import GraphQLSchema
     from typing import Any, Optional, Dict, Callable, Union
diff --git a/graphql/backend/core.py b/graphql/backend/core.py
@@ -8,6 +8,7 @@
 
 from .base import GraphQLBackend, GraphQLDocument
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Optional, Union
     from .base import GraphQLDocument
diff --git a/graphql/backend/decider.py b/graphql/backend/decider.py
@@ -1,5 +1,6 @@
 from .base import GraphQLBackend, GraphQLDocument
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import List, Union, Any, Optional
     from ..type.schema import GraphQLSchema
diff --git a/graphql/error/base.py b/graphql/error/base.py
@@ -1,6 +1,7 @@
 import six
 from ..language.location import get_location
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.source import Source
     from ..language.location import SourceLocation
diff --git a/graphql/error/format_error.py b/graphql/error/format_error.py
@@ -2,6 +2,7 @@
 
 from .base import GraphQLError
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from .base import GraphQLError
     from .located_error import GraphQLLocatedError
diff --git a/graphql/error/located_error.py b/graphql/error/located_error.py
@@ -2,6 +2,7 @@
 
 from .base import GraphQLError
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import Field
     from typing import List, Union
diff --git a/graphql/error/syntax_error.py b/graphql/error/syntax_error.py
@@ -1,6 +1,7 @@
 from ..language.location import get_location
 from .base import GraphQLError
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.source import Source
     from ..language.location import SourceLocation
diff --git a/graphql/error/tests/test_base.py b/graphql/error/tests/test_base.py
@@ -5,6 +5,7 @@
 from graphql.language.parser import parse
 from graphql.type import GraphQLField, GraphQLObjectType, GraphQLSchema, GraphQLString
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from graphql.execution.base import ResolveInfo
     from typing import Any
diff --git a/graphql/execution/base.py b/graphql/execution/base.py
@@ -12,6 +12,7 @@
 )
 from ..error.format_error import format_error as default_format_error
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Optional, Dict, List, Union
     from ..language.ast import Field, OperationDefinition
diff --git a/graphql/execution/executor.py b/graphql/execution/executor.py
@@ -35,6 +35,7 @@
 from .executors.sync import SyncExecutor
 from .middleware import MiddlewareManager
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Optional, Union, Dict, List, Callable
     from rx import Observable
diff --git a/graphql/execution/executors/asyncio.py b/graphql/execution/executors/asyncio.py
@@ -4,6 +4,7 @@
 
 from promise import Promise
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from asyncio.unix_events import _UnixSelectorEventLoop
     from typing import Optional, Any, Callable, List
diff --git a/graphql/execution/executors/sync.py b/graphql/execution/executors/sync.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Callable
 
diff --git a/graphql/execution/executors/thread.py b/graphql/execution/executors/thread.py
@@ -4,6 +4,7 @@
 from promise import Promise
 from .utils import process
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Callable, List
 
diff --git a/graphql/execution/executors/utils.py b/graphql/execution/executors/utils.py
@@ -1,5 +1,6 @@
 from sys import exc_info
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..base import ResolveInfo
     from promise import Promise
diff --git a/graphql/execution/middleware.py b/graphql/execution/middleware.py
@@ -4,6 +4,7 @@
 
 from promise import Promise, promisify
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from .base import ResolveInfo
     from typing import Any, Callable, Iterator, Tuple, Union, List, Dict, Iterable
diff --git a/graphql/execution/tests/test_nonnull.py b/graphql/execution/tests/test_nonnull.py
@@ -12,6 +12,7 @@
 
 from .utils import rejected, resolved
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from promise import Promise
     from typing import Any, Optional, Dict, Tuple, Union
diff --git a/graphql/execution/tests/test_subscribe.py b/graphql/execution/tests/test_subscribe.py
@@ -15,6 +15,7 @@
     subscribe,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from graphql.execution.base import ResolveInfo
     from rx import Observable
diff --git a/graphql/execution/utils.py b/graphql/execution/utils.py
@@ -15,6 +15,7 @@
 from ..utils.type_from_ast import type_from_ast
 from .values import get_argument_values, get_variable_values
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.definition import GraphQLObjectType, GraphQLField
     from ..type.schema import GraphQLSchema
diff --git a/graphql/execution/values.py b/graphql/execution/values.py
@@ -18,6 +18,7 @@
 from ..utils.type_from_ast import type_from_ast
 from ..utils.value_from_ast import value_from_ast
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import VariableDefinition, Argument
     from ..type.schema import GraphQLSchema
diff --git a/graphql/graphql.py b/graphql/graphql.py
@@ -3,6 +3,7 @@
 
 from promise import promisify
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from rx import Observable
     from typing import Any, Union, Optional
diff --git a/graphql/language/ast.py b/graphql/language/ast.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from .parser import Loc
     from typing import Any, Optional, Union, List, Tuple, Iterable
diff --git a/graphql/language/lexer.py b/graphql/language/lexer.py
@@ -4,6 +4,7 @@
 
 from ..error import GraphQLSyntaxError
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Optional, Any, List
     from .source import Source
diff --git a/graphql/language/location.py b/graphql/language/location.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from .source import Source
     from typing import Any
diff --git a/graphql/language/parser.py b/graphql/language/parser.py
@@ -5,6 +5,7 @@
 from .lexer import Lexer, TokenKind, get_token_desc, get_token_kind_desc
 from .source import Source
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Dict, Union, Any, Optional, Callable, List
     from ..error.syntax_error import GraphQLSyntaxError
diff --git a/graphql/language/printer.py b/graphql/language/printer.py
@@ -2,6 +2,7 @@
 
 from .visitor import Visitor, visit
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, List, Optional, Union
     from graphql.language.ast import (
diff --git a/graphql/language/visitor.py b/graphql/language/visitor.py
@@ -5,6 +5,7 @@
 from . import ast
 from .visitor_meta import QUERY_DOCUMENT_KEYS, VisitorMeta
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, List, Optional, Union, Tuple, Dict
     from ..utils.type_info import TypeInfo
diff --git a/graphql/pyutils/cached_property.py b/graphql/pyutils/cached_property.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any
 
diff --git a/graphql/pyutils/contain_subset.py b/graphql/pyutils/contain_subset.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Dict
 
diff --git a/graphql/pyutils/default_ordered_dict.py b/graphql/pyutils/default_ordered_dict.py
@@ -1,6 +1,7 @@
 import copy
 from collections import OrderedDict
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, List
 
@@ -18,7 +19,7 @@ def __init__(self, default_factory=None, *a, **kw):
         self.default_factory = default_factory
 
     def __missing__(self, key):
-        # type: (str) -> List
+        # type: (str) -> Any
         if self.default_factory is None:
             raise KeyError(key)
         self[key] = value = self.default_factory()
diff --git a/graphql/pyutils/pair_set.py b/graphql/pyutils/pair_set.py
@@ -1,3 +1,4 @@
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Dict, Any
 
diff --git a/graphql/type/definition.py b/graphql/type/definition.py
@@ -7,6 +7,7 @@
 from ..utils.assert_valid_name import assert_valid_name
 from ..utils.undefined import Undefined
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import List, Dict, Any, Callable, Optional, Union, Type
 
diff --git a/graphql/type/introspection.py b/graphql/type/introspection.py
@@ -18,6 +18,7 @@
 from .directives import DirectiveLocation
 from .scalars import GraphQLBoolean, GraphQLString
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..execution.base import ResolveInfo
     from .definition import GraphQLInputObjectField
diff --git a/graphql/type/scalars.py b/graphql/type/scalars.py
@@ -3,6 +3,7 @@
 from ..language.ast import BooleanValue, FloatValue, IntValue, StringValue
 from .definition import GraphQLScalarType
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, Optional, Union
 
diff --git a/graphql/type/schema.py b/graphql/type/schema.py
@@ -5,6 +5,7 @@
 from .introspection import IntrospectionSchema
 from .typemap import GraphQLTypeMap
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from .definition import (
         GraphQLNamedType,
diff --git a/graphql/type/typemap.py b/graphql/type/typemap.py
@@ -15,6 +15,7 @@
     is_output_type,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.definition import GraphQLNamedType
     from typing import Any, List, Optional, Union, Dict, Set, Mapping, DefaultDict
diff --git a/graphql/utils/ast_to_code.py b/graphql/utils/ast_to_code.py
@@ -1,6 +1,7 @@
 from ..language.ast import Node
 from ..language.parser import Loc
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any
 
diff --git a/graphql/utils/concat_ast.py b/graphql/utils/concat_ast.py
@@ -2,6 +2,7 @@
 
 from ..language.ast import Document
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Iterable
 
diff --git a/graphql/utils/get_field_def.py b/graphql/utils/get_field_def.py
@@ -5,6 +5,7 @@
     TypeNameMetaFieldDef,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import Field
     from ..type.definition import GraphQLField, GraphQLInterfaceType, GraphQLObjectType
diff --git a/graphql/utils/get_operation_ast.py b/graphql/utils/get_operation_ast.py
@@ -1,5 +1,6 @@
 from ..language import ast
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import Document, OperationDefinition
     from typing import Optional
diff --git a/graphql/utils/is_valid_literal_value.py b/graphql/utils/is_valid_literal_value.py
@@ -8,6 +8,7 @@
     GraphQLScalarType,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import ObjectValue, StringValue
     from ..type.definition import GraphQLInputObjectType, GraphQLScalarType
diff --git a/graphql/utils/is_valid_value.py b/graphql/utils/is_valid_value.py
@@ -15,6 +15,7 @@
     GraphQLScalarType,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import Any, List
 
diff --git a/graphql/utils/quoted_or_list.py b/graphql/utils/quoted_or_list.py
@@ -1,5 +1,6 @@
 import functools
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import List
 
diff --git a/graphql/utils/schema_printer.py b/graphql/utils/schema_printer.py
@@ -11,6 +11,7 @@
 from .ast_from_value import ast_from_value
 
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.definition import (
         GraphQLArgument,
diff --git a/graphql/utils/type_comparators.py b/graphql/utils/type_comparators.py
@@ -7,6 +7,7 @@
     is_abstract_type,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.definition import (
         GraphQLScalarType,
diff --git a/graphql/utils/type_from_ast.py b/graphql/utils/type_from_ast.py
@@ -1,6 +1,7 @@
 from ..language import ast
 from ..type.definition import GraphQLList, GraphQLNonNull
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import ListType, NamedType, NonNullType
     from ..type.definition import GraphQLNamedType
diff --git a/graphql/utils/type_info.py b/graphql/utils/type_info.py
@@ -11,6 +11,7 @@
 from .get_field_def import get_field_def
 from .type_from_ast import type_from_ast
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..type.schema import GraphQLSchema
     from ..type.definition import (
diff --git a/graphql/utils/value_from_ast.py b/graphql/utils/value_from_ast.py
@@ -7,6 +7,7 @@
     GraphQLScalarType,
 )
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from ..language.ast import Node
     from ..type.definition import GraphQLType
diff --git a/graphql/validation/rules/__init__.py b/graphql/validation/rules/__init__.py
@@ -23,6 +23,7 @@
 from .variables_are_input_types import VariablesAreInputTypes
 from .variables_in_allowed_position import VariablesInAllowedPosition
 
+# Necessary for static type checking
 if False:  # flake8: noqa
     from typing import List, Type
     from .base import ValidationRule
diff --git a/graphql/validation/rules/arguments_of_correct_type.py b/graphql/validation/rules/arguments_of_correct_type.py
diff --git a/graphql/validation/rules/base.py b/graphql/validation/rules/base.py
diff --git a/graphql/validation/rules/default_values_of_correct_type.py b/graphql/validation/rules/default_values_of_correct_type.py
diff --git a/graphql/validation/rules/fields_on_correct_type.py b/graphql/validation/rules/fields_on_correct_type.py
diff --git a/graphql/validation/rules/fragments_on_composite_types.py b/graphql/validation/rules/fragments_on_composite_types.py
diff --git a/graphql/validation/rules/known_argument_names.py b/graphql/validation/rules/known_argument_names.py
diff --git a/graphql/validation/rules/known_type_names.py b/graphql/validation/rules/known_type_names.py
diff --git a/graphql/validation/rules/lone_anonymous_operation.py b/graphql/validation/rules/lone_anonymous_operation.py
diff --git a/graphql/validation/rules/no_fragment_cycles.py b/graphql/validation/rules/no_fragment_cycles.py
diff --git a/graphql/validation/rules/no_undefined_variables.py b/graphql/validation/rules/no_undefined_variables.py
diff --git a/graphql/validation/rules/no_unused_fragments.py b/graphql/validation/rules/no_unused_fragments.py
diff --git a/graphql/validation/rules/no_unused_variables.py b/graphql/validation/rules/no_unused_variables.py
diff --git a/graphql/validation/rules/overlapping_fields_can_be_merged.py b/graphql/validation/rules/overlapping_fields_can_be_merged.py
diff --git a/graphql/validation/rules/possible_fragment_spreads.py b/graphql/validation/rules/possible_fragment_spreads.py
diff --git a/graphql/validation/rules/provided_non_null_arguments.py b/graphql/validation/rules/provided_non_null_arguments.py
diff --git a/graphql/validation/rules/scalar_leafs.py b/graphql/validation/rules/scalar_leafs.py
diff --git a/graphql/validation/rules/unique_argument_names.py b/graphql/validation/rules/unique_argument_names.py
diff --git a/graphql/validation/rules/unique_fragment_names.py b/graphql/validation/rules/unique_fragment_names.py
diff --git a/graphql/validation/rules/unique_input_field_names.py b/graphql/validation/rules/unique_input_field_names.py
diff --git a/graphql/validation/rules/unique_operation_names.py b/graphql/validation/rules/unique_operation_names.py
diff --git a/graphql/validation/rules/unique_variable_names.py b/graphql/validation/rules/unique_variable_names.py
diff --git a/graphql/validation/rules/variables_in_allowed_position.py b/graphql/validation/rules/variables_in_allowed_position.py
diff --git a/graphql/validation/validation.py b/graphql/validation/validation.py
