php-lib-db: add log functions and replace die

die(), which is an alias for exit, outputs its message to stdout
which will be sent to the client making debugging hard. Errors will
now be logged to the php error log.

References: GXL-53

Author: Victor Tesla

exch/php/lib/db.php

@@ -12,23 +12,24 @@ function get_db_connection()
 	$config = get_app_config();
 	$db_config = $config['database'];
 	if (!isset($db_config)) {
-		die("cannot find [database] section in config file");
+		_log_db("cannot find [database] section in config file");
 	}
 	if (!isset($db_config['host'])) {
-		die("cannot find host under [database] in config file");
+		_log_db("cannot find host under [database] in config file");
 	}
 	if (!isset($db_config['username'])) {
-		die("cannot find username under [database] in config file");
+		_log_db("cannot find username under [database] in config file");
 	}
 	if (!isset($db_config['password'])) {
-		die("cannot find password under [database] in config file");
+		_log_db("cannot find password under [database] in config file");
 	}
 	if (!isset($db_config['dbname'])) {
-		die("cannot find dbname under [database] in config file");
+		_log_db("cannot find dbname under [database] in config file");
 	}
 	$db_conn = mysqli_connect($db_config['host'], $db_config['username'], $db_config['password'], $db_config['dbname']);
-	if ($db_conn->connect_errno) {
-		die("Failed to connect to database server: " . $db_conn->connect_error);
+	$e = mysqli_connect_errno();
+	if ($e != 0) {
+		_log_db("Failed to connect to database server: " . $e);
 	}
 	return $db_conn;
 }
@@ -40,7 +41,7 @@ function get_user_info_by_name($email_address)
 	$sql_string = "SELECT maildir, '', username, id, domain_id, timezone FROM users WHERE username='" . $db_conn->real_escape_string($email_address) . "'";
 	$results = $db_conn->query($sql_string);
 	if (!$results) {
-		die("fail to query database: " . $db_conn->error);
+		_log_db("fail to query database: " . $db_conn->error);
 	}
 	if (1 != mysqli_num_rows($results)) {
 		return NULL;
@@ -65,7 +66,7 @@ function get_user_info_by_name($email_address)
 	$sql_string = "SELECT proptag, propval_str FROM users INNER JOIN user_properties AS up ON users.id=up.user_id WHERE users.username='" . $db_conn->real_escape_string($email_address) . "'";
 	$results = $db_conn->query($sql_string);
 	if (!$results)
-		die("failed to query database: " . $db_conn->error);
+		_log_db("failed to query database: " . $db_conn->error);
 	while (($row = $results->fetch_row())) {
 		if ($row[0] == 805371935)
 			$data_array["real_name"] = $row[1];
@@ -80,7 +81,7 @@ function get_user_info_by_id($user_id)
 	$sql_string = "SELECT maildir, '', username, id, domain_id, timezone FROM users WHERE id=" . $user_id;
 	$results = $db_conn->query($sql_string);
 	if (!$results) {
-		die("fail to query database: " . $db_conn->error);
+		_log_db("fail to query database: " . $db_conn->error);
 	}
 	if (1 != mysqli_num_rows($results)) {
 		return NULL;
@@ -105,7 +106,7 @@ function get_user_info_by_id($user_id)
 	$sql_string = "SELECT proptag, propval_str FROM users INNER JOIN user_properties AS up ON users.id=up.user_id WHERE users.id=" . $user_id;
 	$results = $db_conn->query($sql_string);
 	if (!$results)
-		die("failed to query database: " . $db_conn->error);
+		_log_db("failed to query database: " . $db_conn->error);
 	while (($row = $results->fetch_row())) {
 		if ($row[0] == 805371935)
 			$data_array["real_name"] = $row[1];
@@ -120,7 +121,7 @@ function get_domain_info_by_name($domain)
 	$sql_string = "SELECT homedir, id, domainname FROM domains WHERE domainname='" . $db_conn->real_escape_string($domain) . "'";
 	$results = $db_conn->query($sql_string);
 	if (!$results) {
-		die("fail to query database: " . $db_conn->error);
+		_log_db("fail to query database: " . $db_conn->error);
 	}
 	if (1 != mysqli_num_rows($results)) {
 		return NULL;
@@ -136,7 +137,7 @@ function get_domain_info_by_id($domain_id)
 	$sql_string = "SELECT homedir, id, domainname FROM domains WHERE id=" . $domain_id;
 	$results = $db_conn->query($sql_string);
 	if (!$results) {
-		die("fail to query database: " . $db_conn->error);
+		_log_db("fail to query database: " . $db_conn->error);
 	}
 	if (1 != mysqli_num_rows($results)) {
 		return NULL;
@@ -152,7 +153,7 @@ function get_domains()
 	$sql_string = "SELECT domainname FROM domains";
 	$results = $db_conn->query($sql_string);
 	if (!$results) {
-		die("fail to query database: " . $db_conn->error);
+		_log_db("fail to query database: " . $db_conn->error);
 	}
 	$domains = array();
 	for ($i = 0; $i < mysqli_num_rows($results); ++$i) {

exch/php/lib/util.php

@@ -208,4 +208,17 @@ function get_mapihttp_supported()
 	return false;
 }
 
-?>
+function _log($from, $message, $exit=-1)
+{
+	error_log($from . ": " . $message);
+	if ($exit >= 0) {
+		exit($exit);
+	}
+}
+
+function _log_db($message)
+{
+	_log("gromox-php-db", $message, 0);
+}
+
+?>