generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Labels
DependencyWaiting for other issue ready before this issueWaiting for other issue ready before this issueParticipant type: Admindeck: staging not for stakeholderStaging deck https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fgStaging deck https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fgdev: technical debtReimplement a former quick fix in a more robust way to ease future development and maintenance.Reimplement a former quick fix in a more robust way to ease future development and maintenance.feature: Code Cleanuplevel: easypriority: SHOULD HAVErole: front-endFront End DeveloperFront End Developersize: 0.25ptCan be done in 1.5 hours or lessCan be done in 1.5 hours or less
Milestone
Description
Dependency
Overview
I'm seeing some deprecation warning when running the client code in docker. It has to do with the @import rule being deprecated. I made the fix.
Action Items
- make the fix. Transition to using @use rule
-
figure out how to see the deprecation messages when running on localhostit's because of the sass version being used. see comment below about node versions - figure out if this allows us to use a higher sass version and which one is stable.
- make PR ready for review
Resources/Instructions
-
Output of deprecation warnings
click to expand
client-1 | VITE v6.2.5 ready in 311 ms
client-1 |
client-1 | ➜ Local: http://localhost:3000/
client-1 | ➜ Network: http://172.21.0.3:3000/
client-1 | DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
client-1 |
client-1 | More info and automated migrator: https://sass-lang.com/d/import
client-1 |
client-1 | ╷
client-1 | 2 │ @import "./reset.scss";
client-1 | │ ^^^^^^^^^^^^^^
client-1 | ╵
client-1 | src/styles/App.scss 2:9 root stylesheet
client-1 |
client-1 | DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
client-1 |
client-1 | More info and automated migrator: https://sass-lang.com/d/import
client-1 |
client-1 | ╷
client-1 | 3 │ @import "_variables.scss";
client-1 | │ ^^^^^^^^^^^^^^^^^
client-1 | ╵
client-1 | src/styles/App.scss 3:9 root stylesheet
client-1 |
client-1 | DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
client-1 |
client-1 | More info and automated migrator: https://sass-lang.com/d/import
client-1 |
client-1 | ╷
client-1 | 191 │ @import "./AuthForms.scss"; // Login and Register components
client-1 | │ ^^^^^^^^^^^^^^^^^^
client-1 | ╵
client-1 | src/styles/App.scss 191:9 root stylesheet
client-1 |
client-1 | DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
client-1 |
client-1 | More info and automated migrator: https://sass-lang.com/d/import
client-1 |
client-1 | ╷
client-1 | 1 │ @import "./_variables_ladot.scss";
client-1 | │ ^^^^^^^^^^^^^^^^^^^^^^^^^
client-1 | ╵
client-1 | src/styles/_variables.scss 1:9 @import
client-1 | src/styles/App.scss 3:9 root stylesheet
Metadata
Metadata
Assignees
Labels
DependencyWaiting for other issue ready before this issueWaiting for other issue ready before this issueParticipant type: Admindeck: staging not for stakeholderStaging deck https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fgStaging deck https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fgdev: technical debtReimplement a former quick fix in a more robust way to ease future development and maintenance.Reimplement a former quick fix in a more robust way to ease future development and maintenance.feature: Code Cleanuplevel: easypriority: SHOULD HAVErole: front-endFront End DeveloperFront End Developersize: 0.25ptCan be done in 1.5 hours or lessCan be done in 1.5 hours or less
Type
Projects
Status
Ice Box