Skip to content

Commit 8b6661d

Browse files
committed
Update ember-try matrix (#3202)
1 parent d1a5593 commit 8b6661d

File tree

3 files changed

+8
-36
lines changed

3 files changed

+8
-36
lines changed

.changeset/fluffy-places-ask.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hashicorp/design-system-components": major
3+
---
4+
5+
Removed support for Ember 3.28. New minimum support target is Ember 4.12.

.github/workflows/ci-components.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
pull_request: {}
88

99
env:
10-
NODE_VERSION: '22.x'
10+
NODE_VERSION: "22.x"
1111

1212
concurrency:
1313
group: ci-components-${{ github.head_ref || github.ref }}
@@ -28,7 +28,7 @@ jobs:
2828
run: ./.github/scripts/filter_changed_files.sh "packages/components" "packages/flight-icons/catalog.json" "showcase" ".github/workflows/ci-components.yml" "packages/tokens"
2929

3030
test:
31-
name: 'Tests'
31+
name: "Tests"
3232
runs-on: ubuntu-latest
3333
needs: [conditional-skip]
3434
if: needs.conditional-skip.outputs.trigger-ci == 'true'
@@ -63,13 +63,12 @@ jobs:
6363
try-scenarios:
6464
name: ${{ matrix.try-scenario }}
6565
runs-on: ubuntu-latest
66-
needs: 'test'
66+
needs: "test"
6767

6868
strategy:
6969
fail-fast: false
7070
matrix:
7171
try-scenario:
72-
- ember-lts-3.28
7372
- ember-lts-4.12
7473
# - ember-release
7574
- ember-beta

showcase/config/ember-try.js

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,6 @@ module.exports = async function () {
1313
command: 'ember test --filter="integration" --reporter xunit',
1414
packageManager: 'pnpm',
1515
scenarios: [
16-
{
17-
name: 'ember-lts-3.28',
18-
allowedToFail: true,
19-
npm: {
20-
devDependencies: {
21-
'@ember/test-helpers': '^2.0.0',
22-
'ember-a11y-testing': '^5.2.1',
23-
'ember-cli': '~3.28.0',
24-
'ember-qunit': '^6.0.0',
25-
'ember-resolver': '^8.1.0',
26-
'ember-source': '~3.28.11',
27-
},
28-
},
29-
},
3016
{
3117
name: 'ember-lts-4.12',
3218
npm: {
@@ -59,24 +45,6 @@ module.exports = async function () {
5945
},
6046
},
6147
},
62-
{
63-
name: 'ember-classic',
64-
env: {
65-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
66-
'application-template-wrapper': true,
67-
'default-async-observers': false,
68-
'template-only-glimmer-components': false,
69-
}),
70-
},
71-
npm: {
72-
devDependencies: {
73-
'ember-source': '~3.28.0',
74-
},
75-
ember: {
76-
edition: 'classic',
77-
},
78-
},
79-
},
8048
embroiderSafe(),
8149
embroiderOptimized(),
8250
],

0 commit comments

Comments
 (0)