[Draft] Initial qcow2 firmware support #226
Open
+72
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR to add support for using EFI firmware in qcow2 format.
Merging this PR allows the plugin to keep up with the modern approach taken by distributions like Fedora which have retired raw versions of the 4M firmware images in their
edk2package in favour of only shipping qcow2 versions.This approach is unlikely to be reverted. I asked one of the maintainers about this and was told:
So since it does not appear that this approach will go away, and other distros will likely follow suit, it makes sense for the plugin to update to handle this situation.
I have tested this and it works on a Fedora host using the
edk2package and these EFI variables passed to a Packer QEMU source:I think what I'm mostly missing here is updating tests to account for this new acceptable scenario of qcow2 firmware, and also updating documentation.
This is a draft PR as I'm not super familiar with the codebase so feedback is very welcome on what might be needed to merge it!
Resolved Issues
Rollback Plan
Unknown. Please advise.
This is a minimal change but I assume as it's quite a clean single PR it could easily be reverted if necessary.
Changes to Security Controls
None.