Add parameterized resource identity to aws_route_table

jar-b · jar-b · commit 46270d8f061f · 2025-08-21T13:26:20.000-04:00
Adds resource identity support to the `aws_route_table` resource. This
is a parameterized resource with a single attribute, `id`, corresponding
to the route table ID generated by AWS during creation.

```console
% make testacc PKG=vpc TESTS=TestAccVPCRouteTable_
make: Verifying source code with gofmt...
==&gt; Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTable_'  -timeout 360m -vet=off
2025/08/21 13:17:04 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/21 13:17:04 Initializing Terraform AWS Provider (SDKv2-style)...

=== NAME  TestAccVPCRouteTable_ipv4ToCarrierGateway
    wavelength_carrier_gateway_test.go:198: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRouteTable_ipv4ToCarrierGateway (0.97s)
=== CONT  TestAccVPCRouteTable_Disappears_subnetAssociation
=== NAME  TestAccVPCRouteTable_ipv4ToLocalGateway
    vpc_route_table_test.go:495: skipping since no Outposts found
--- SKIP: TestAccVPCRouteTable_ipv4ToLocalGateway (0.97s)
=== CONT  TestAccVPCRouteTable_tags_EmptyMap
--- PASS: TestAccVPCRouteTable_requireRouteTarget (19.75s)
=== CONT  TestAccVPCRouteTable_ipv4ToNatGateway
--- PASS: TestAccVPCRouteTable_disappears (28.20s)
=== CONT  TestAccVPCRouteTable_conditionalCIDRBlock
--- PASS: TestAccVPCRouteTable_Disappears_subnetAssociation (36.47s)
=== CONT  TestAccVPCRouteTable_Identity_ExistingResource
--- PASS: TestAccVPCRouteTable_ipv4ToVPCPeeringConnection (43.15s)
=== CONT  TestAccVPCRouteTable_tags
--- PASS: TestAccVPCRouteTable_gatewayVPCEndpoint (51.46s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCRouteTable_ipv4ToInternetGateway (54.56s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_overlapping
--- PASS: TestAccVPCRouteTable_IPv6ToNetworkInterface_unattached (57.32s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCRouteTable_Identity_Basic (59.24s)
=== CONT  TestAccVPCRouteTable_Identity_RegionOverride
--- PASS: TestAccVPCRouteTable_vpcMultipleCIDRs (61.01s)
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCRouteTable_tags_null (62.69s)
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCRouteTable_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCRouteTable_tags_EmptyMap (62.09s)
--- PASS: TestAccVPCRouteTable_tags_AddOnUpdate (69.31s)
=== CONT  TestAccVPCRouteTable_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_updateToProviderOnly (69.89s)
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnCreate (71.42s)
=== CONT  TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway (73.04s)
=== CONT  TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCRouteTable_Route_mode (95.32s)
=== CONT  TestAccVPCRouteTable_localRoute
--- PASS: TestAccVPCRouteTable_basic (37.07s)
=== CONT  TestAccVPCRouteTable_localRouteImportUpdate
--- PASS: TestAccVPCRouteTable_conditionalCIDRBlock (73.56s)
=== CONT  TestAccVPCRouteTable_localRouteAdoptUpdate
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnCreate (41.95s)
=== CONT  TestAccVPCRouteTable_ipv4ToVPCEndpoint
--- PASS: TestAccVPCRouteTable_ipv4ToInstance (104.02s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCRouteTable_Identity_RegionOverride (51.99s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCRouteTable_IPv4ToNetworkInterfaces_unattached (113.85s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCRouteTable_Identity_ExistingResource (78.37s)
=== CONT  TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCRouteTable_localRoute (39.07s)
=== CONT  TestAccVPCRouteTable_ipv4ToTransitGateway
--- PASS: TestAccVPCRouteTable_requireRouteDestination (138.48s)
=== CONT  TestAccVPCRouteTable_prefixListToInternetGateway
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Replace (69.80s)
=== CONT  TestAccVPCRouteTable_multipleRoutes
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Replace (70.14s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCRouteTable_tags_ComputedTag_OnUpdate_Add (73.52s)
=== CONT  TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_emptyProviderOnlyTag (43.76s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nullNonOverlappingResourceTag (40.17s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nullOverlappingResourceTag (41.32s)
--- PASS: TestAccVPCRouteTable_tags_IgnoreTags_Overlap_DefaultTag (86.41s)
--- PASS: TestAccVPCRouteTable_tags_IgnoreTags_Overlap_ResourceTag (93.90s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_nonOverlapping (107.59s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_overlapping (111.61s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_emptyResourceTag (29.39s)
--- PASS: TestAccVPCRouteTable_tags (130.41s)
--- PASS: TestAccVPCRouteTable_prefixListToInternetGateway (36.61s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_providerOnly (127.03s)
--- PASS: TestAccVPCRouteTable_vgwRoutePropagation (178.90s)
--- PASS: TestAccVPCRouteTable_localRouteAdoptUpdate (78.25s)
--- PASS: TestAccVPCRouteTable_tags_EmptyTag_OnUpdate_Add (72.19s)
--- PASS: TestAccVPCRouteTable_tags_DefaultTags_updateToResourceOnly (43.74s)
--- PASS: TestAccVPCRouteTable_localRouteImportUpdate (102.11s)
--- PASS: TestAccVPCRouteTable_ipv4ToNatGateway (197.80s)
--- PASS: TestAccVPCRouteTable_multipleRoutes (143.25s)
--- PASS: TestAccVPCRouteTable_ipv4ToVPCEndpoint (370.55s)
--- PASS: TestAccVPCRouteTable_ipv4ToTransitGateway (399.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        540.977s
```
diff --git a/internal/service/ec2/service_package_gen.go b/internal/service/ec2/service_package_gen.go
diff --git a/internal/service/ec2/testdata/RouteTable/basic/main_gen.tf b/internal/service/ec2/testdata/RouteTable/basic/main_gen.tf
@@ -0,0 +1,11 @@
+# Copyright (c) HashiCorp, Inc.
+# SPDX-License-Identifier: MPL-2.0
+
+resource "aws_route_table" "test" {
+  vpc_id = aws_vpc.test.id
+}
+
+resource "aws_vpc" "test" {
+  cidr_block = "10.1.0.0/16"
+}
+
diff --git a/internal/service/ec2/testdata/RouteTable/basic_v6.9.0/main_gen.tf b/internal/service/ec2/testdata/RouteTable/basic_v6.9.0/main_gen.tf
@@ -0,0 +1,21 @@
+# Copyright (c) HashiCorp, Inc.
+# SPDX-License-Identifier: MPL-2.0
+
+resource "aws_route_table" "test" {
+  vpc_id = aws_vpc.test.id
+}
+
+resource "aws_vpc" "test" {
+  cidr_block = "10.1.0.0/16"
+}
+
+terraform {
+  required_providers {
+    aws = {
+      source  = "hashicorp/aws"
+      version = "6.9.0"
+    }
+  }
+}
+
+provider "aws" {}
diff --git a/internal/service/ec2/testdata/RouteTable/region_override/main_gen.tf b/internal/service/ec2/testdata/RouteTable/region_override/main_gen.tf
@@ -0,0 +1,21 @@
+# Copyright (c) HashiCorp, Inc.
+# SPDX-License-Identifier: MPL-2.0
+
+resource "aws_route_table" "test" {
+  region = var.region
+
+  vpc_id = aws_vpc.test.id
+}
+
+resource "aws_vpc" "test" {
+  region = var.region
+
+  cidr_block = "10.1.0.0/16"
+}
+
+
+variable "region" {
+  description = "Region to deploy resource in"
+  type        = string
+  nullable    = false
+}
diff --git a/internal/service/ec2/testdata/tmpl/vpc_route_table_tags.gtpl b/internal/service/ec2/testdata/tmpl/vpc_route_table_tags.gtpl
@@ -1,9 +1,11 @@
 resource "aws_route_table" "test" {
+{{- template "region" }}
   vpc_id = aws_vpc.test.id
 
 {{- template "tags" . }}
 }
 
 resource "aws_vpc" "test" {
+{{- template "region" }}
   cidr_block = "10.1.0.0/16"
 }
diff --git a/internal/service/ec2/vpc_route_table.go b/internal/service/ec2/vpc_route_table.go
@@ -51,17 +51,15 @@ var routeTableValidTargets = []string{
 // @Tags(identifierAttribute="id")
 // @Testing(existsType="github.com/aws/aws-sdk-go-v2/service/ec2/types;awstypes;awstypes.RouteTable")
 // @Testing(generator=false)
+// @IdentityAttribute("id")
+// @Testing(preIdentityVersion="v6.9.0")
 func resourceRouteTable() *schema.Resource {
 	return &schema.Resource{
 		CreateWithoutTimeout: resourceRouteTableCreate,
 		ReadWithoutTimeout:   resourceRouteTableRead,
 		UpdateWithoutTimeout: resourceRouteTableUpdate,
 		DeleteWithoutTimeout: resourceRouteTableDelete,
 
-		Importer: &schema.ResourceImporter{
-			StateContext: schema.ImportStatePassthroughContext,
-		},
-
 		Timeouts: &schema.ResourceTimeout{
 			Create: schema.DefaultTimeout(5 * time.Minute),
 			Update: schema.DefaultTimeout(2 * time.Minute),
diff --git a/internal/service/ec2/vpc_route_table_identity_gen_test.go b/internal/service/ec2/vpc_route_table_identity_gen_test.go

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,11 @@`
`1`	`1`	`resource "aws_route_table" "test" {`
	`2`	`+{{- template "region" }}`
`2`	`3`	`vpc_id = aws_vpc.test.id`
`3`	`4`
`4`	`5`	`{{- template "tags" . }}`
`5`	`6`	`}`
`6`	`7`
`7`	`8`	`resource "aws_vpc" "test" {`
	`9`	`+{{- template "region" }}`
`8`	`10`	`cidr_block = "10.1.0.0/16"`
`9`	`11`	`}`