Skip to content

Commit 3707013

Browse files
committed
DO NOT MERGE: unwrap udp test directly
1 parent c0da5ac commit 3707013

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

xtask/src/ci/qemu.rs

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ impl Qemu {
119119
qemu.stdin(Stdio::piped()).stdout(Stdio::piped());
120120
}
121121

122-
let mut qemu = KillChildOnDrop(qemu.spawn().context("Failed to spawn QEMU")?);
122+
let mut qemu = KillChildOnDrop(qemu.spawn().context("Failed to spawn QEMU").unwrap());
123123

124124
thread::sleep(Duration::from_millis(100));
125-
if let Some(status) = qemu.0.try_wait()? {
125+
if let Some(status) = qemu.0.try_wait().unwrap() {
126126
ensure!(
127127
self.qemu_success(status, arch),
128128
"QEMU exit code: {:?}",
@@ -134,14 +134,14 @@ impl Qemu {
134134

135135
match image_name {
136136
"axum-example" | "http_server" | "http_server_poll" | "http_server_select" => {
137-
test_http_server(guest_ip)?
137+
test_http_server(guest_ip).unwrap()
138138
}
139-
"httpd" => test_httpd(guest_ip)?,
140-
"testudp" => test_testudp(guest_ip)?,
141-
"miotcp" => test_miotcp(guest_ip)?,
142-
"mioudp" => test_mioudp(guest_ip)?,
143-
"poll" => test_poll(guest_ip)?,
144-
"stdin" => test_stdin(&mut qemu.0)?,
139+
"httpd" => test_httpd(guest_ip).unwrap(),
140+
"testudp" => test_testudp(guest_ip).unwrap(),
141+
"miotcp" => test_miotcp(guest_ip).unwrap(),
142+
"mioudp" => test_mioudp(guest_ip).unwrap(),
143+
"poll" => test_poll(guest_ip).unwrap(),
144+
"stdin" => test_stdin(&mut qemu.0).unwrap(),
145145
_ => {}
146146
}
147147

@@ -151,10 +151,10 @@ impl Qemu {
151151
) || self.devices.contains(&Device::CadenceGem)
152152
// sifive_u, on which we test CadenceGem, does not support software shutdowns, so we have to kill the machine ourselves.
153153
{
154-
qemu.0.kill()?;
154+
qemu.0.kill().unwrap();
155155
}
156156

157-
let status = qemu.0.wait_timeout(Duration::from_secs(60 * 6))?;
157+
let status = qemu.0.wait_timeout(Duration::from_secs(60 * 6)).unwrap();
158158
let Some(status) = status else {
159159
bail!("QEMU timeout")
160160
};
@@ -165,12 +165,12 @@ impl Qemu {
165165
);
166166

167167
if let Some(mut virtiofsd) = virtiofsd {
168-
let status = virtiofsd.0.wait()?;
168+
let status = virtiofsd.0.wait().unwrap();
169169
assert!(status.success());
170170
}
171171

172172
if image_name.contains("rftrace") {
173-
check_rftrace(image)?;
173+
check_rftrace(image).unwrap();
174174
}
175175

176176
Ok(())
@@ -559,9 +559,9 @@ fn test_testudp(guest_ip: IpAddr) -> Result<()> {
559559
let buf = "exit";
560560
let socket_addr = SocketAddr::new(guest_ip, 9975);
561561
eprintln!("[CI] send {buf:?} via UDP to {socket_addr}");
562-
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
563-
socket.connect(socket_addr)?;
564-
socket.send(buf.as_bytes())?;
562+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0)).unwrap();
563+
socket.connect(socket_addr).unwrap();
564+
socket.send(buf.as_bytes()).unwrap();
565565

566566
Ok(())
567567
}
@@ -571,11 +571,11 @@ fn test_miotcp(guest_ip: IpAddr) -> Result<()> {
571571
let buf = "exit";
572572
let socket_addr = SocketAddr::new(guest_ip, 9975);
573573
eprintln!("[CI] send {buf:?} via TCP to {socket_addr}");
574-
let mut stream = TcpStream::connect(socket_addr)?;
575-
stream.write_all(buf.as_bytes())?;
574+
let mut stream = TcpStream::connect(socket_addr).unwrap();
575+
stream.write_all(buf.as_bytes()).unwrap();
576576

577577
let mut buf = vec![];
578-
let received = stream.read_to_end(&mut buf)?;
578+
let received = stream.read_to_end(&mut buf).unwrap();
579579
eprintln!("[CI] receive: {}", from_utf8(&buf[..received])?);
580580

581581
Ok(())
@@ -601,14 +601,14 @@ fn test_mioudp(guest_ip: IpAddr) -> Result<()> {
601601
let buf = "exit";
602602
let socket_addr = SocketAddr::new(guest_ip, 9975);
603603
eprintln!("[CI] send {buf:?} via UDP to {socket_addr}");
604-
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
605-
socket.connect(socket_addr)?;
606-
socket.send(buf.as_bytes())?;
604+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0)).unwrap();
605+
socket.connect(socket_addr).unwrap();
606+
socket.send(buf.as_bytes()).unwrap();
607607

608-
socket.set_read_timeout(Some(Duration::from_secs(10)))?;
608+
socket.set_read_timeout(Some(Duration::from_secs(10))).unwrap();
609609
let mut buf = [0; 128];
610-
let received = socket.recv(&mut buf)?;
611-
eprintln!("[CI] receive: {}", from_utf8(&buf[..received])?);
610+
let received = socket.recv(&mut buf).unwrap();
611+
eprintln!("[CI] receive: {}", from_utf8(&buf[..received]).unwrap());
612612

613613
Ok(())
614614
}

0 commit comments

Comments
 (0)