Skip to content

Commit 8459add

Browse files
fix: #1221 move block node Protobuf files to fix import mismatch (#1223)
* Moved block node api and internal to block-node folder * Updated protobuf artifact script to maintain the new folder structure * Verified all clients still function without change (no package changes in generated files) Signed-off-by: Joseph S <121976561+jsync-swirlds@users.noreply.github.com>
1 parent cd7cd7b commit 8459add

12 files changed

+12
-22
lines changed

protobuf/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*.tgz

protobuf/build.gradle.kts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ val generateBlockNodeProtoArtifact: TaskProvider<Exec> =
2828
commandLine(
2929
"sh",
3030
"-c",
31-
"${layout.projectDirectory}/scripts/build-bn-proto.sh -t $cnTagHash -v ${project.version} -o ${layout.projectDirectory}/block-node-protobuf -i false -b ${layout.projectDirectory}/src/main/proto/org/hiero/block/api",
31+
"${layout.projectDirectory}/scripts/build-bn-proto.sh -t $cnTagHash -v ${project.version} -o ${layout.projectDirectory}/block-node-protobuf -i true -b ${layout.projectDirectory}/src/main/proto/",
3232
)
3333
}
3434

@@ -56,20 +56,16 @@ sourceSets {
5656
pbj {
5757
srcDir(
5858
generateBlockNodeProtoArtifact.map {
59-
"${layout.projectDirectory}/block-node-protobuf"
59+
"${layout.projectDirectory}/block-node-protobuf/"
6060
}
6161
)
62-
// exclude BN files at root level
63-
exclude("*.proto")
6462
}
6563
proto {
6664
srcDir(
6765
generateBlockNodeProtoArtifact.map {
68-
"${layout.projectDirectory}/block-node-protobuf"
66+
"${layout.projectDirectory}/block-node-protobuf/"
6967
}
7068
)
71-
// exclude BN files at root level
72-
exclude("*.proto")
7369
}
7470
}
7571
}

protobuf/scripts/build-bn-proto.sh

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function usage {
2323
echo " -i bool Flag if BN API proto should be included, if false no artifact is created"
2424
echo " (example: true, default is true)"
2525
echo " -b string BN API path"
26-
echo " (assumes wordkingDir is protobuf module, default is src/main/proto/org/hiero/block/api)"
26+
echo " (assumes wordkingDir is protobuf module, default is src/main/proto/)"
2727
echo ""
2828
}
2929

@@ -67,7 +67,7 @@ fi
6767
# handle defaults for optional fields
6868
cleanup="${cleanup:-false}"
6969
include_bn_api="${include_bn_api:-true}"
70-
bn_api_path="${bn_api_path:-src/main/proto/org/hiero/block/api}"
70+
bn_api_path="${bn_api_path:-src/main/proto/}"
7171

7272
echo "Running $0, working directory: $PWD"
7373
echo "repository_tag: $repository_tag, release_version: $release_version, output_dir: $output_dir, cleanup: $cleanup, include_bn_api: $include_bn_api, bn_api_path: $bn_api_path ..."
@@ -103,15 +103,9 @@ cp -r ./hiero-consensus-node/hapi/hedera-protobuf-java-api/src/main/proto/servic
103103
# Copy CN 'streams' protobuf files to the output_dir directory
104104
cp -r ./hiero-consensus-node/hapi/hedera-protobuf-java-api/src/main/proto/streams "$output_dir"
105105

106-
if $include_bn_api; then
107-
# Copy BN repo protobuf files to the new directory
108-
echo "Copy BN API proto src:'$bn_api_path' to target:'$output_dir' directory"
109-
cp -r $bn_api_path/* "$output_dir/"
110-
fi
111-
112106
if $include_bn_api; then
113107
# create artifact file if BN APIs are included
114-
tar -czf "block-node-protobuf-$release_version.tgz" -C "./$output_dir" .
108+
tar -czf "block-node-protobuf-$release_version.tgz" -C "$output_dir" . -C ${bn_api_path} ./block-node
115109
echo "CN + BN proto artifact 'block-node-protobuf-$release_version.tgz' successfully created."
116110
fi
117111

@@ -120,10 +114,9 @@ if $cleanup; then
120114
rm -rf ./hiero-consensus-node
121115

122116
echo "Cleaning up intermediate "$output_dir" directory"
123-
rm -rf "./$output_dir"
117+
rm -rf "$output_dir"
124118
fi
125119

126-
127120
if [ $? -eq 0 ]; then
128121
echo "CN proto retrieval and $output_dir contents successfully created."
129122
else

protobuf/src/main/proto/org/hiero/block/api/block_stream_publish_service.proto renamed to protobuf/src/main/proto/block-node/api/block_stream_publish_service.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ option java_package = "org.hiero.block.api.protoc";
77
// <<<pbj.java_package = "org.hiero.block.api">>> This comment is special code for setting PBJ Compiler java package
88
option java_multiple_files = true;
99

10-
import "org/hiero/block/api/shared_message_types.proto";
10+
import "block-node/api/shared_message_types.proto";
1111

1212
/**
1313
* Publish a stream of block items.

protobuf/src/main/proto/org/hiero/block/api/block_stream_subscribe_service.proto renamed to protobuf/src/main/proto/block-node/api/block_stream_subscribe_service.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ option java_package = "org.hiero.block.api.protoc";
77
// <<<pbj.java_package = "org.hiero.block.api">>> This comment is special code for setting PBJ Compiler java package
88
option java_multiple_files = true;
99

10-
import "org/hiero/block/api/shared_message_types.proto";
10+
import "block-node/api/shared_message_types.proto";
1111

1212
/**
1313
* A request to stream block items from block node to a client.

protobuf/src/main/proto/org/hiero/block/internal/unparsed.proto renamed to protobuf/src/main/proto/internal/unparsed.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ option java_package = "org.hiero.block.internal.protoc";
77
// <<<pbj.java_package = "org.hiero.block.internal">>> This comment is special code for setting PBJ Compiler java package
88
option java_multiple_files = true;
99

10-
import "org/hiero/block/api/block_access_service.proto";
11-
import "org/hiero/block/api/block_stream_subscribe_service.proto";
10+
import "block-node/api/block_access_service.proto";
11+
import "block-node/api/block_stream_subscribe_service.proto";
1212

1313
message PublishStreamRequestUnparsed {
1414
BlockItemSetUnparsed block_items = 1;

0 commit comments

Comments
 (0)